From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7DF5C433DB for ; Tue, 16 Mar 2021 10:32:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B11265026 for ; Tue, 16 Mar 2021 10:32:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236685AbhCPKbo (ORCPT ); Tue, 16 Mar 2021 06:31:44 -0400 Received: from smtp119.ord1c.emailsrvr.com ([108.166.43.119]:49558 "EHLO smtp119.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236699AbhCPKbc (ORCPT ); Tue, 16 Mar 2021 06:31:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20190130-41we5z8j; t=1615890691; bh=mwT18wqfxXbfbbf/yugkbhkjXJijF9Lw3D4H5UEXS9U=; h=Subject:To:From:Date:From; b=BD71bKwa9+JKcLzdXjZ67fVULd/XFLCyoD91IwMIMy+9SGxQHo1Ev/LKgykFNbTMD I6lr375E/514QcNoMcHET6mtXZVLR2dRPmsC/y8T2ZoJNubpeWgYyWoQWAUelbBbnV gMmkw9jFw8CdYXtjz36ntiykyGcqxC0du1OHZaoo= X-Auth-ID: abbotti@mev.co.uk Received: by smtp15.relay.ord1c.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id DE4B220126; Tue, 16 Mar 2021 06:31:30 -0400 (EDT) Subject: Re: [PATCH v2] staging: comedi: cb_pcidas64: fix request_irq() warn To: Tong Zhang , H Hartley Sweeten , Greg Kroah-Hartman , "Alexander A. Klimov" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <858341a6-c105-1440-aa4d-ea0217f2ec89@mev.co.uk> <20210315195814.4692-1-ztong0001@gmail.com> From: Ian Abbott Organization: MEV Ltd. Message-ID: Date: Tue, 16 Mar 2021 10:31:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210315195814.4692-1-ztong0001@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Classification-ID: 6cf650db-b512-42c3-a719-2d044d753507-1-1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/03/2021 19:58, Tong Zhang wrote: > request_irq() wont accept a name which contains slash so we need to > repalce it with something else -- otherwise it will trigger a warning > and the entry in /proc/irq/ will not be created > since the .name might be used by userspace and we don't want to break > userspace, so we are changing the parameters passed to request_irq() > > [ 1.565966] name 'pci-das6402/16' > [ 1.566149] WARNING: CPU: 0 PID: 184 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0 > [ 1.568923] RIP: 0010:__xlate_proc_name+0x93/0xb0 > [ 1.574200] Call Trace: > [ 1.574722] proc_mkdir+0x18/0x20 > [ 1.576629] request_threaded_irq+0xfe/0x160 > [ 1.576859] auto_attach+0x60a/0xc40 [cb_pcidas64] > > Suggested-by: Ian Abbott > Signed-off-by: Tong Zhang > --- > v2: revert changes to .name field so that we dont break userspace > > drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c > index fa987bb0e7cd..6d3ba399a7f0 100644 > --- a/drivers/staging/comedi/drivers/cb_pcidas64.c > +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c > @@ -4035,7 +4035,7 @@ static int auto_attach(struct comedi_device *dev, > init_stc_registers(dev); > > retval = request_irq(pcidev->irq, handle_interrupt, IRQF_SHARED, > - dev->board_name, dev); > + "cb_pcidas64", dev); > if (retval) { > dev_dbg(dev->class_dev, "unable to allocate irq %u\n", > pcidev->irq); > Looks good. Reviewed-by: Ian Abbott -- -=( Ian Abbott || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-