From: saravanan sekar <sravanhome@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: robh+dt@kernel.org, jic23@kernel.org, knaack.h@gmx.de,
lars@metafoo.de, pmeerw@pmeerw.net, sre@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 1/5] dt-bindings: mfd: add document bindings for mp2629
Date: Tue, 7 Apr 2020 18:29:52 +0200 [thread overview]
Message-ID: <e4412378-1423-a48e-9176-f0d48f6000c4@gmail.com> (raw)
In-Reply-To: <20200330064630.GA30614@dell>
Hi Lee,
On 30/03/20 8:46 am, Lee Jones wrote:
> On Fri, 27 Mar 2020, saravanan sekar wrote:
>> On 27/03/20 9:00 am, Lee Jones wrote:
>>> On Sun, 22 Mar 2020, Saravanan Sekar wrote:
>>>
>>>> Add device tree binding information for mp2629 mfd driver.
>>>>
>>>> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
>>>> ---
>>>> .../devicetree/bindings/mfd/mps,mp2629.yaml | 60 +++++++++++++++++++
>>>> 1 file changed, 60 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
>>>> new file mode 100644
>>>> index 000000000000..314309ea91ac
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
>>>> @@ -0,0 +1,60 @@
>>>> +# SPDX-License-Identifier: GPL-2.0
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/mfd/mps,mp2629.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> Are these links supposed to work?
>> Not really, but as far my understanding needed for dt-bindings check
> Rob, why are these here if they just result in 404s?
>
>>>> +examples:
>>>> + - |
>>>> + #include <dt-bindings/interrupt-controller/irq.h>
>>>> + #include <dt-bindings/input/linux-event-codes.h>
>>>> + i2c {
>>> i2c@0x????????
>> Its a I2C controller node, I don't think address is needed. Mention like
>> this my previous other driver patches,
> This doesn't sound right.
>
> How do you control/operate the controller?
>
> Surely you read/write from/to registers?
Indeed, but each SoC will have different address so which address to
mention here.
For me it should be like &i2c {}, anyhow I respect maintainers review (I
can give RPi I2c bus address used for testing)
and wait for Rob's reply
>
>> dt_binding_check is also passed
>>
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> +
>>>> + pmic@4b {
>>>> + compatible = "mps,mp2629";
>>>> + reg = <0x4b>;
>>>> +
>>>> + interrupt-controller;
>>>> + interrupt-parent = <&gpio2>;
>>>> + #interrupt-cells = <2>;
>>>> + interrupts = <3 IRQ_TYPE_LEVEL_HIGH>;
>>>> + };
>>>> + };
next prev parent reply other threads:[~2020-04-07 16:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 22:46 [PATCH v4 0/5] Add battery charger driver support for MP2629 Saravanan Sekar
2020-03-22 22:46 ` [PATCH v4 1/5] dt-bindings: mfd: add document bindings for mp2629 Saravanan Sekar
2020-03-27 8:00 ` Lee Jones
2020-03-27 21:50 ` saravanan sekar
2020-03-30 6:46 ` Lee Jones
2020-04-07 16:29 ` saravanan sekar [this message]
2020-04-08 10:15 ` Lee Jones
2020-03-22 22:46 ` [PATCH v4 2/5] mfd: mp2629: Add support for mps battery charger Saravanan Sekar
2020-03-27 7:55 ` Lee Jones
2020-03-27 8:32 ` saravanan sekar
2020-03-27 10:22 ` Lee Jones
2020-03-27 10:56 ` saravanan sekar
2020-03-27 11:25 ` Lee Jones
2020-03-27 12:40 ` saravanan sekar
2020-03-27 12:56 ` Andy Shevchenko
2020-03-27 13:03 ` saravanan sekar
2020-03-27 13:17 ` Andy Shevchenko
2020-03-28 14:36 ` Jonathan Cameron
2020-03-22 22:46 ` [PATCH v4 3/5] iio: adc: mp2629: Add support for mp2629 ADC driver Saravanan Sekar
2020-03-22 23:32 ` Andy Shevchenko
2020-03-28 14:42 ` Jonathan Cameron
2020-03-28 18:50 ` Andy Shevchenko
2020-03-29 10:37 ` saravanan sekar
2020-03-29 11:09 ` Andy Shevchenko
2020-03-22 22:46 ` [PATCH v4 4/5] power: supply: Add support for mps mp2629 battery charger Saravanan Sekar
2020-03-22 23:26 ` Andy Shevchenko
2020-03-23 12:29 ` saravanan sekar
2020-03-22 22:46 ` [PATCH v4 5/5] MAINTAINERS: Add entry for mp2629 Battery Charger driver Saravanan Sekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4412378-1423-a48e-9176-f0d48f6000c4@gmail.com \
--to=sravanhome@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).