From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 685D4ECE59D for ; Wed, 16 Oct 2019 06:24:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37A8120873 for ; Wed, 16 Oct 2019 06:24:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="KLCmiSQd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388357AbfJPGYx (ORCPT ); Wed, 16 Oct 2019 02:24:53 -0400 Received: from mout.web.de ([217.72.192.78]:59159 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387646AbfJPGYx (ORCPT ); Wed, 16 Oct 2019 02:24:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1571207070; bh=0p6dSM6PENsJyEfXE4U7vsSYM0mBFd/NXBg3mvut6gg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=KLCmiSQdxe9okohtHqmP9HHG4ERukQSBUHkfzQvn6bfTgPb2Amf5AmLPAtprXU7/L px4a3EpH1/7qbJOJTQTSw1LOMcaF5rAsQw1GoRiuSmcVkEApi0hh8Hy1aYEV/jKjrH AEruZxD4kKJcgBpAf0DVu846s3FK387oUvAwcD3U= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.135.85.206]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MLgQp-1iKLU52WN1-000r1q; Wed, 16 Oct 2019 08:24:30 +0200 Subject: Re: clk: rockchip: Checking a kmemdup() call in rockchip_clk_register_pll() To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, Michael Turquette , Stephen Boyd , Aditya Pakki , Kangjie Lu , Navid Emamdoost , Stephen McCamant , LKML References: <2588953.0pqkEXWxhN@phil> <45588ab8-2a6c-3f29-61ff-bccf8d6fb291@web.de> <5173392.uhhkXBHGmO@phil> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Wed, 16 Oct 2019 08:24:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <5173392.uhhkXBHGmO@phil> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:i+Z1+vuuVeMv0jTbPGmTYTQ7in95qy9wdCmNE9Qjmm19nTEhAhG 8uzMHUg0b5Lkx0DtpREcdxWvKzErJ5Rf0mVKBXOtYx556scFVkNYU6jj+C581nQfA0jvX8g v5fCSja7D5O2mXL6QgARY9Je5FGwjNYmQcoNglnmWzarjKflkTQ062BH7ifApZYM4gtuUFi 9xhxvYNzLX+wYqdtlPTfw== X-UI-Out-Filterresults: notjunk:1;V03:K0:YDX/EkHvGXc=:o2jLrnfPJ5YRyb2d0eDp6n V8v9536ArQwkb77EFMR86TTl1kmHENcCXRjcDhyBCSFwwzpuUBioBlkWMVU9V8m9IayNj797G jigyvRKl3rSUHPA5cyhqKAXgZ7H3eq2pXTLA4gELrv3HKhfF5pJkiPb56VitwNJWgFMFX6zzw nOP/OEX6Llo3xU5PGd/Eha14VEjgH1bmrW5YoB7AvGC3XN03sdHygii+CAZ2p4zS3aGDcbPgZ mtbSevU7+vkCfP2tc9bgAu1Ra5R55WHFqLyFKnVWCfwcYFzO/IgFT+JC6wyA+VGZ+En3yw6tB HUrR3p9v8g8bp3iSA2O7NOvZ4GxoKxFNCxRM6Ze3O18ujD7V9z8bg9uBoEpuuFSkfYK94Qgg3 FKWe3sBxxen0nrICa+LLyX0fwq6zdv+1H4qNiP3J7ORq3lF06t60o45wFx3JioMX9cBAwgZqe v4Z9v6Qnc9Wong3eiBQQ6BN0/f8h9uypeOLGmBV/JwxbAYJ/LZbgYBwbed8L5UDWQQaFs7Vc0 3OHAs+Z0BIdUKg8rjEKzG4iwjXWzkwS//b1OW4Gj1L0z/r+vBPrg2az0nQduOWqQtcj7APFf4 C9ZwE7Vr9T++U3oU7mUSi2ohLYPYG8n75VA6MbvOBsTvYjUl7Ss2XTnT9QCKEzDeFzqr1b2lX jf+R0SdjakoEzxZg7ZUQMHyKof+k9tJxjlqT414gP64oVK7bHgSPQdoOFas5Jjsfe6oFIgmoK s4EvJTF+4xJVfKjyS+z5xIGsNbTfTqeFQ2nvSXY2McB3dTnbVvg6Yv+jiVQw0r+hSbbWU/Ud7 y+/Hh74jVWcubUyOPbIykusLAdSkq2aZUSraBB1jMYpzh8JmNeJkUykJ7tX3s3+tbUSJKEqwc ppIW3XH69bwSi9W2ILsUEC3wB4uJT3XH5UMVdwiU6aw8tPD7mL/RmPPCtn05X5ewsVL3jloN4 tjbJAF/bDuboVkB2imzaMqePdHBDVcnJy8tAkGExDu95zUtbneATS8JPSHfTxSxeuZGVgEsN/ wtZcwutSv6OmhKMugxs1MNHnkyAjdWfvzPB88Sf53Y+AE7SdB2cWOlqEzWWVxKWjleDBrIzjS OPRofIOdPIRj2Uo3QSyYHkDgBLT18fckbRnVIy01TpZpGbsdhU0u53vlXZeL/gv03Yj+j/MNk 4q4sZVuAyDcK4SlcJumO0ANHs+wtgqk1zAwSLvmG5bHXYrv7N3Uo5zUr+lmGr/n0JXb7qKegC auvHsmsP/ZfRxh2fCSum5nPUfSxCGMtoj1wIrnYwfMEPMPfEO4ixGmpn42MI= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Would you like to adjust such exception handling another bit? > > Nope. > > The big difference is that clocks rely heavily on their names to establi= sh > the clock tree parentship. So the PLL cannot work without the name This error situation got a specific reaction. > but can provide some means of functionality without the rate-table > especially as bootloaders do generally initialize a PLL to some form of > sane frequency. I imagine that a choice is available here for the error handling strategy. * Return =E2=80=9CERR_PTR(-ENOMEM)=E2=80=9D as a strict response like in t= he other error case. * Fix the setting =E2=80=9Cpll->rate_count=E2=80=9D at least (to be a bit = more tolerant). Would any system users wonder then about the availability of only a single frequency (instead of possibly expected alternatives)? Regards, Markus