From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F2CC433E0 for ; Thu, 6 Aug 2020 01:34:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 004022173E for ; Thu, 6 Aug 2020 01:34:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726844AbgHFBeD (ORCPT ); Wed, 5 Aug 2020 21:34:03 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:8770 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725998AbgHFBeD (ORCPT ); Wed, 5 Aug 2020 21:34:03 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 6E60EC939619170D8DC9; Thu, 6 Aug 2020 09:34:00 +0800 (CST) Received: from [127.0.0.1] (10.74.173.29) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Thu, 6 Aug 2020 09:33:51 +0800 Subject: Re: [v4 01/10] crypto: hisilicon/qm - fix wrong release after using strsep To: Markus Elfring , Sihang Chen , References: <96ffa633-dda1-7ad1-72da-5563906c1561@web.de> <425f4bdd-cf55-6537-28bf-0377564b531b@huawei.com> <5554863d-f0d7-a396-7d13-e187fa9ca6bf@web.de> CC: , , "David S. Miller" , Herbert Xu , Zaibo Xu , Zhou Wang From: "shenyang (M)" Message-ID: Date: Thu, 6 Aug 2020 09:33:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <5554863d-f0d7-a396-7d13-e187fa9ca6bf@web.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.74.173.29] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/8/5 14:04, Markus Elfring wrote: >> Thanks for your review. There is only one error branch need to do >> something uninit. So I think the jump is not necessary and will >> affect code reading.:) > > How does this concern fit to the Linux coding style? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=4da9f3302615f4191814f826054846bf843e24fa#n481 > > Regards, > Markus > > . > Got it, I'll fix this. Thanks, Yang