From: Mark Bloch <markb@mellanox.com>
To: Kenneth Lee <liguozhu@hisilicon.com>, <dledford@redhat.com>,
<sean.hefty@intel.com>, <hal.rosenstock@gmail.com>
Cc: <robin.murphy@arm.com>, <jroedel@suse.de>, <egtvedt@samfundet.no>,
<vgupta@synopsys.com>, <dave.hansen@linux.intel.com>,
<lstoakes@gmail.com>, <krzk@kernel.org>,
<sebott@linux.vnet.ibm.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ib umem: bug: put pid back before return from error path
Date: Thu, 22 Dec 2016 10:00:57 +0200 [thread overview]
Message-ID: <e470fbab-a330-b9c4-f2b3-65fb45f24e0a@mellanox.com> (raw)
In-Reply-To: <1482390692-147946-1-git-send-email-liguozhu@hisilicon.com>
Hi,
You have two bugs here:
1) When using ODP, ib_umem_release() checks for umem->odp_data != NULL
calls ib_umem_odp_release() and returns immediately without calling put_pid().
This one isn't in the error path so the title doesn't fit.
2) In case the allocation failed, we return in -ENOMEM without calling put_pid().
Can you please resend this with proper fixes line and a better description of what is going on.
On 22/12/2016 09:11, Kenneth Lee wrote:
> I catched this bug when reading the code. I'm sorry I have no hardware to test
> it. But it is abviously a bug.
>
> Signed-off-by: Kenneth Lee <liguozhu@hisilicon.com>
> ---
> drivers/infiniband/core/umem.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
> index 1e62a5f..4609b92 100644
> --- a/drivers/infiniband/core/umem.c
> +++ b/drivers/infiniband/core/umem.c
> @@ -134,6 +134,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
> IB_ACCESS_REMOTE_ATOMIC | IB_ACCESS_MW_BIND));
>
> if (access & IB_ACCESS_ON_DEMAND) {
> + put_pid(umem->pid);
> ret = ib_umem_odp_get(context, umem);
> if (ret) {
> kfree(umem);
> @@ -149,6 +150,7 @@ struct ib_umem *ib_umem_get(struct ib_ucontext *context, unsigned long addr,
>
> page_list = (struct page **) __get_free_page(GFP_KERNEL);
> if (!page_list) {
> + put_pid(umem->pid);
> kfree(umem);
> return ERR_PTR(-ENOMEM);
> }
>
Mark.
next prev parent reply other threads:[~2016-12-22 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 7:11 [PATCH] ib umem: bug: put pid back before return from error path Kenneth Lee
2016-12-22 8:00 ` Mark Bloch [this message]
2016-12-29 2:28 ` Kenneth Lee
2016-12-22 11:03 ` Haggai Eran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e470fbab-a330-b9c4-f2b3-65fb45f24e0a@mellanox.com \
--to=markb@mellanox.com \
--cc=dave.hansen@linux.intel.com \
--cc=dledford@redhat.com \
--cc=egtvedt@samfundet.no \
--cc=hal.rosenstock@gmail.com \
--cc=jroedel@suse.de \
--cc=krzk@kernel.org \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=robin.murphy@arm.com \
--cc=sean.hefty@intel.com \
--cc=sebott@linux.vnet.ibm.com \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).