From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751387AbdFDVIE (ORCPT ); Sun, 4 Jun 2017 17:08:04 -0400 Received: from mout.web.de ([212.227.17.12]:49559 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202AbdFDVH5 (ORCPT ); Sun, 4 Jun 2017 17:07:57 -0400 Subject: [PATCH 3/3] arm/xen: Adjust one function call together with a variable assignment From: SF Markus Elfring To: linux-arm-kernel@lists.infradead.org, xen-devel@lists.xenproject.org, Russell King , Stefano Stabellini Cc: LKML , kernel-janitors@vger.kernel.org References: <9b9230f4-0f00-e019-75b4-571e29b52998@users.sourceforge.net> Message-ID: Date: Sun, 4 Jun 2017 23:07:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <9b9230f4-0f00-e019-75b4-571e29b52998@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:9lrIAqGYCkfA0s3vmLt4mJctD9nYZBuJUwwLzX+AkyixbAUY1FM RLVzbMsSwNOxU7SDziEcqG57szXsGnQ1cwDCrYhvajfllQ1IYjoy0gflF4kENNlqlbtKG6i ulDVUMe+DKqIK3qYkhkqg7H2/Qezvbk5oGPMND0M+vRP7x9pw/Maq8VFxVY7g6irc+kRNJt oftfGouC6JEARWRX0ds7A== X-UI-Out-Filterresults: notjunk:1;V01:K0:dihTfcyQs+Q=:eKTAC4uqc7F+6q4he0cHCF D5Yw+xsCiX7j89rgFcEGULnK877GEGvRnOV25FdAhEIbEX4fVALSUpi8YVXQSDSC0kJY7q4tr 6S1r4Jcf9tUYvQQOdLoExKpVFzvaduXnaHcp4Z2TVPL16ej0PtPDSU5sYPgm7ytaygOjZnvnn zrFEetgk4OEKaH3pil6gZefQkUHi23D8ewWN0uBDV/ZBvUQbsGHiErQLRDfFHNwnHC0XrxUyk hQaV/kNx2CXNA70uwxCpSLxxCbcItR7AhELJO/a7wUKkXQjqvm6kfcbT2xDVt8kX7E3TwuYC9 vVCckZsMgdvsA4LHvSe71LziSFwRnQg86bLJys3CCau+vEp4MRa2iRmj/KzxNsUt1WK1xDBeC yBvz/bO7KjRMtrxpwmcU5iaMq5ed5ThMvSekqecCe5tSdU5FFHtdtzpyGqD20b1y86ET3JcKD IqC8fNIdrTpquij5F5/bDUbegKNDg5NbKdUPSX1/ZWUvt2qRl9aFTbib0zACnUOMcZznJVFox wxT60QoqmK9bQWIQEDse3xtPHmafjQhQpUeBvVD/ui0sl7NJQ9QeCYEHB1ujQbix3sIf44GSF trPtCXK/wkbuQA0zqBeV9BuQL1Gk0tlHC/uHLNwVP7NUD9JDpCT8Zx5Q2pIjPjCzUiliN7v4i zMDPEj+kCt9i9V9941dWKIDFEGT8HQyEOXkpelGBbzjK8fTaEqp02gjJKTfWV1WdEJcw5B6If k5m8tTb4hKOzeUii61ubOTdrVnf5yvu9ZPtGBkydlCSjCcf3wJut6BwLhX1qSZQUW6FnosaG2 H5PXlsH Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 4 Jun 2017 21:21:20 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code place. Signed-off-by: Markus Elfring --- arch/arm/xen/p2m.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/xen/p2m.c b/arch/arm/xen/p2m.c index f5f74ac637b9..e71eefa2e427 100644 --- a/arch/arm/xen/p2m.c +++ b/arch/arm/xen/p2m.c @@ -153,7 +153,8 @@ bool __set_phys_to_machine_multi(unsigned long pfn, p2m_entry->mfn = mfn; write_lock_irqsave(&p2m_lock, irqflags); - if ((rc = xen_add_phys_to_mach_entry(p2m_entry)) < 0) { + rc = xen_add_phys_to_mach_entry(p2m_entry); + if (rc < 0) { write_unlock_irqrestore(&p2m_lock, irqflags); return false; } -- 2.13.0