From: Adrian Hunter <adrian.hunter@intel.com>
To: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>,
ulf.hansson@linaro.org
Cc: stummala@codeaurora.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
stable@vger.kernel.org, Baolin Wang <baolin.wang@linaro.org>,
Avri Altman <avri.altman@wdc.com>,
Chaotian Jing <chaotian.jing@mediatek.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH V1 1/2] mmc: core: Check request type before completing the request
Date: Wed, 6 May 2020 20:06:29 +0300 [thread overview]
Message-ID: <e4f7515c-e52e-f909-174a-8835d7e9e445@intel.com> (raw)
In-Reply-To: <1588775643-18037-2-git-send-email-vbadigan@codeaurora.org>
On 6/05/20 5:34 pm, Veerabhadrarao Badiganti wrote:
> In the request completion path with CQE, request type is being checked
> after the request is getting completed. This is resulting in returning
> the wrong request type and leading to the IO hang issue.
>
> ASYNC request type is getting returned for DCMD type requests.
> Because of this mismatch, mq->cqe_busy flag is never getting cleared
> and the driver is not invoking blk_mq_hw_run_queue. So requests are not
> getting dispatched to the LLD from the block layer.
>
> All these eventually leading to IO hang issues.
> So, get the request type before completing the request.
>
> Cc: <stable@vger.kernel.org> # v4.19+
The fixed commit was in 4.16
> Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
Fixes: 1e8e55b67030 ("mmc: block: Add CQE support")
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Thank you for finding this!
> ---
> drivers/mmc/core/block.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index 8499b56..c5367e2 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -1370,6 +1370,7 @@ static void mmc_blk_cqe_complete_rq(struct mmc_queue *mq, struct request *req)
> struct mmc_request *mrq = &mqrq->brq.mrq;
> struct request_queue *q = req->q;
> struct mmc_host *host = mq->card->host;
> + enum mmc_issue_type issue_type = mmc_issue_type(mq, req);
> unsigned long flags;
> bool put_card;
> int err;
> @@ -1399,7 +1400,7 @@ static void mmc_blk_cqe_complete_rq(struct mmc_queue *mq, struct request *req)
>
> spin_lock_irqsave(&mq->lock, flags);
>
> - mq->in_flight[mmc_issue_type(mq, req)] -= 1;
> + mq->in_flight[issue_type] -= 1;
>
> put_card = (mmc_tot_in_flight(mq) == 0);
>
>
next prev parent reply other threads:[~2020-05-06 17:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 14:34 [PATCH V1 0/2] CQE fixes Veerabhadrarao Badiganti
2020-05-06 14:34 ` [PATCH V1 1/2] mmc: core: Check request type before completing the request Veerabhadrarao Badiganti
2020-05-06 17:06 ` Adrian Hunter [this message]
2020-05-08 8:12 ` Ulf Hansson
2020-05-06 14:34 ` [PATCH V1 2/2] mmc: core: Fix recursive locking issue in CQE recovery path Veerabhadrarao Badiganti
2020-05-07 11:48 ` Adrian Hunter
2020-05-07 14:06 ` [PATCH] mmc: block: Fix request completion in the CQE timeout path Adrian Hunter
2020-05-08 5:25 ` Ulf Hansson
2020-05-08 6:22 ` [PATCH RESEND] " Adrian Hunter
2020-05-08 8:17 ` Ulf Hansson
2020-05-07 16:15 ` [PATCH V2] mmc: core: Fix recursive locking issue in CQE recovery path Veerabhadrarao Badiganti
2020-05-07 17:21 ` Adrian Hunter
2020-05-08 8:12 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4f7515c-e52e-f909-174a-8835d7e9e445@intel.com \
--to=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=avri.altman@wdc.com \
--cc=baolin.wang@linaro.org \
--cc=chaotian.jing@mediatek.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).