From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932861AbcITKc7 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Sep 2016 06:32:59 -0400
Received: from mout.web.de ([212.227.17.12]:59589 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932227AbcITKc5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Sep 2016 06:32:57 -0400
Subject: Re: GPU-DRM-GMA500: One error message less for a GCT revision
 mismatch in mid_get_vbt_data()
To: Jani Nikula <jani.nikula@linux.intel.com>
References: <566ABCD9.1060404@users.sourceforge.net>
 <3c9785ef-4553-2e3d-2cb2-5cf6d1f31ccd@users.sourceforge.net>
 <287833f5-f1ad-b7f0-c614-d4c903b1c890@users.sourceforge.net>
 <87shsulw9k.fsf@intel.com>
Cc: dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
        David Airlie <airlied@linux.ie>,
        Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
        Julia Lawall <julia.lawall@lip6.fr>, kernel-janitors@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <e5062794-7d14-f4dc-2995-949f84b62810@users.sourceforge.net>
Date: Tue, 20 Sep 2016 12:32:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <87shsulw9k.fsf@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:BD8SmfKvEipdPhW3B/Nnwp+N5vjULkaitjTnyTo8xbuq/S62gDU
 3vP79WV1Fn4grgi3VFTSpCfQi88beZZgByWAWwimit8viVoOM2GuFZAf8aG6xy0ZBviRsid
 dhkKI6QkInOZXzJbdJDtOa44iAPwBZvfk5a/4jdgyleoNiBPqGx6OtZ2zTUVu2HtmxFbwML
 XMvLR6S1ege4aIHdtvuGw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:1D46fP8JLNg=:VlZVT0dsTUqF737zYyoN4z
 b5V39pFblE9nRipk400QEFIxPFornIyuLx2r/GDAcRl7G5YvEUQgh2cAU3vVUG+4ay+Q+OYyy
 2yIZKEuCnHxrUezDQ4CMBZH8aXoBN4H1BsnTEi9oeYfieG9CtPfGiw8zVV18O1csP2alDidym
 BXrj3kILOJvNqFSChbQk1jwIsQPN4J+oovtMWGTHNmMRl0O/0oX3qlm14Fq4sQvE6TbEIzGpo
 SiGNXJsR2076sFM/jY00Ghlm+52syMMqM34y6Klk3+1+zAj2nilnoKmjuRnNI8URtAg0rZwEl
 LvxGLZ6/gCEsMllBpp15LyKohHqGydHoHx2ppCxmYEfQiY9gK7H/zn9J2+r2FYW/QD83itaW4
 Oa+bAB3NfewarvqVrDD+eZvaME+UgvgYU5m4+pxHWsIFskedYL807YZvMAGZeSORLl/H+EBZU
 sEqri9xX/Zk9BNdu+J4yrzA7U1Pu4K5F7WIw34wfmQ+vvoCcBWzogyJrkKURpUxJoO5rKnjcm
 7HJMpmCNP7idZTmWI38AqopzNqcdFR1NEMZ5nDfQACygjQFII6aDlUg52x/FgO8uJ5tWX1nx/
 2zYo6TOqvNW3yYYBbtUeuQVy5Qmfg5LqrrWuMZgDEA9HIAgsRTkCt1FvoErv9/avvNOa4ozR4
 3NdA5SOIyEF4iGoDxvtkrr4l8unHQQ8Rfy0IFSZYL5YBAJ6dvDRbFiazIgNaAtdH5LKhdd+2x
 kj2UfTn3UEICAmT8+Qq/d6W9q5PMg8KXlZJx/7YCrdcoWGIn6cCpJyVvBkMT6pMdRVfaH+NRk
 sXYvh2L
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> A single error message should be sufficient to inform about
>> the detection of an unknown GCT revision at the end.
>> Thus return after the logging call in this case directly.
> 
> Did you test this?

What is your software development opinion for this update suggestion?

Regards,
Markus