linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Boris Zhmurov <bb@kernelpanic.ru>
To: Michal Hocko <mhocko@kernel.org>
Cc: paulmck@linux.vnet.ibm.com, Paul Menzel <pmenzel@molgen.mpg.de>,
	Donald Buczek <buczek@molgen.mpg.de>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: INFO: rcu_sched detected stalls on CPUs/tasks with `kswapd` and `mem_cgroup_shrink_node`
Date: Thu, 1 Dec 2016 21:10:01 +0300	[thread overview]
Message-ID: <e50dcb85-4552-9249-c53e-017fefcaf80b@kernelpanic.ru> (raw)
In-Reply-To: <20161130182552.GN18432@dhcp22.suse.cz>

[-- Attachment #1: Type: text/plain, Size: 921 bytes --]

Michal Hocko 30/11/16 21:25:

>>> Do I get it right that s@cond_resched_rcu_qs@cond_resched@ didn't help?
>>
>> I didn't try that. I've tried 4 patches from Paul's linux-rcu tree.
>> I can try another portion of patches, no problem :)
> 
> Replacing cond_resched_rcu_qs in shrink_node_memcg by cond_resched would
> be really helpful to tell whether we are missing a real scheduling point
> or whether something more serious is going on here.

Well, I can confirm, that replacing cond_resched_rcu_qs in
shrink_node_memcg by cond_resched also makes dmesg clean from RCU CPU
stall warnings.

I've attached patch (just modification of Paul's patch), that fixes RCU
stall messages in situations, when all memory is used by
couchbase/memcached + fs cache and linux starts to use swap.


-- 
Boris Zhmurov
System/Network Administrator
mailto: bb@kernelpanic.ru
"wget http://kernelpanic.ru/bb_public_key.pgp -O - | gpg --import"

[-- Attachment #2: linux-4.8-mm-prevent-shrink_node_memcg-RCU-CPU-stall-warnings.patch --]
[-- Type: text/x-patch, Size: 297 bytes --]

--- a/mm/vmscan.c.orig	2016-11-30 21:52:58.314895320 +0300
+++ b/mm/vmscan.c	2016-11-30 21:53:29.502895320 +0300
@@ -2352,6 +2352,7 @@
 				nr_reclaimed += shrink_list(lru, nr_to_scan,
 							    lruvec, sc);
 			}
+			cond_resched();
 		}
 
 		if (nr_reclaimed < nr_to_reclaim || scan_adjusted)

       reply	other threads:[~2016-12-01 18:17 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161125212000.GI31360@linux.vnet.ibm.com>
     [not found] ` <20161128095825.GI14788@dhcp22.suse.cz>
     [not found]   ` <20161128105425.GY31360@linux.vnet.ibm.com>
     [not found]     ` <3a4242cb-0198-0a3b-97ae-536fb5ff83ec@kernelpanic.ru>
     [not found]       ` <20161128143435.GC3924@linux.vnet.ibm.com>
     [not found]         ` <eba1571e-f7a8-09b3-5516-c2bc35b38a83@kernelpanic.ru>
     [not found]           ` <20161128150509.GG3924@linux.vnet.ibm.com>
     [not found]             ` <66fd50e1-a922-846a-f427-7654795bd4b5@kernelpanic.ru>
     [not found]               ` <20161130174802.GM18432@dhcp22.suse.cz>
     [not found]                 ` <fd34243c-2ebf-c14b-55e6-684a9dc614e7@kernelpanic.ru>
     [not found]                   ` <20161130182552.GN18432@dhcp22.suse.cz>
2016-12-01 18:10                     ` Boris Zhmurov [this message]
2016-12-01 19:39                       ` INFO: rcu_sched detected stalls on CPUs/tasks with `kswapd` and `mem_cgroup_shrink_node` Paul E. McKenney
2016-12-02  9:37                       ` Michal Hocko
2016-12-02 13:52                         ` Paul E. McKenney
2016-12-02 16:39                       ` Boris Zhmurov
2016-12-02 16:44                         ` Paul E. McKenney
2016-12-02 17:02                           ` Michal Hocko
2016-12-02 17:15                             ` Paul E. McKenney
     [not found] <24c226a5-1a4a-173e-8b4e-5107a2baac04@molgen.mpg.de>
2016-11-08 12:22 ` Paul Menzel
2016-11-08 17:03   ` Paul E. McKenney
2016-11-08 17:38     ` Paul Menzel
2016-11-08 18:39       ` Paul E. McKenney
2016-11-16 17:01         ` Paul Menzel
2016-11-16 17:30           ` Paul E. McKenney
2016-11-21 13:41             ` Michal Hocko
2016-11-21 14:01               ` Paul E. McKenney
2016-11-21 14:18                 ` Michal Hocko
2016-11-21 14:29                   ` Paul E. McKenney
2016-11-21 15:35                     ` Donald Buczek
2016-11-24 10:15                       ` Michal Hocko
2016-11-24 18:50                         ` Donald Buczek
2016-11-27  9:37                           ` Paul Menzel
2016-11-27  5:32                         ` Christopher S. Aker
2016-11-27  9:19                         ` Donald Buczek
2016-11-28 11:04                           ` Michal Hocko
2016-11-28 12:26                             ` Paul Menzel
2016-11-30 10:28                               ` Donald Buczek
2016-11-30 11:09                                 ` Michal Hocko
2016-11-30 11:43                                   ` Donald Buczek
2016-12-02  9:14                                     ` Donald Buczek
2016-12-06  8:32                                       ` Donald Buczek
2016-11-30 11:53                                   ` Paul E. McKenney
2016-11-30 11:54                                     ` Paul E. McKenney
2016-11-30 12:31                                       ` Paul Menzel
2016-11-30 14:31                                         ` Paul E. McKenney
2016-11-30 13:19                                     ` Michal Hocko
2016-11-30 14:29                                       ` Paul E. McKenney
2016-11-30 16:38                                         ` Peter Zijlstra
2016-11-30 17:02                                           ` Paul E. McKenney
2016-11-30 17:05                                           ` Michal Hocko
2016-11-30 17:23                                             ` Paul E. McKenney
2016-11-30 17:34                                               ` Michal Hocko
2016-11-30 17:50                                             ` Peter Zijlstra
2016-11-30 19:40                                               ` Paul E. McKenney
2016-12-01  5:30                                                 ` Peter Zijlstra
2016-12-01 12:40                                                   ` Paul E. McKenney
2016-12-01 16:36                                                     ` Peter Zijlstra
2016-12-01 16:59                                                       ` Paul E. McKenney
2016-12-01 18:09                                                         ` Peter Zijlstra
2016-12-01 18:42                                                           ` Paul E. McKenney
2016-12-01 18:49                                                             ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e50dcb85-4552-9249-c53e-017fefcaf80b@kernelpanic.ru \
    --to=bb@kernelpanic.ru \
    --cc=buczek@molgen.mpg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).