From: Gal Pressman <galpress@amazon.com>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: Max Hirsch <max.hirsch@gmail.com>,
Doug Ledford <dledford@redhat.com>,
Parav Pandit <parav@mellanox.com>,
Steve Wise <swise@opengridcomputing.com>,
Bart Van Assche <bvanassche@acm.org>,
Danit Goldberg <danitg@mellanox.com>,
Matthew Wilcox <willy@infradead.org>,
Dag Moxnes <dag.moxnes@oracle.com>,
Myungho Jung <mhjungk@gmail.com>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/cma: Fix checkpatch error
Date: Thu, 12 Dec 2019 14:10:12 +0200 [thread overview]
Message-ID: <e5123cbb-9871-d9c3-62e9-5b3172d1adf8@amazon.com> (raw)
In-Reply-To: <20191212084907.GU67461@unreal>
On 12/12/2019 10:49, Leon Romanovsky wrote:
> On Wed, Dec 11, 2019 at 12:26:54PM -0400, Jason Gunthorpe wrote:
>> On Wed, Dec 11, 2019 at 11:16:26AM +0000, Max Hirsch wrote:
>>> When running checkpatch on cma.c the following error was found:
>>
>> I think checkpatch will complain about your patch, did you run it?
>
> Jason, Doug
>
> I would like to ask to refrain from accepting checkpatch.pl patches
> which are not part of other large submission. Such standalone cleanups
> do more harm than actual benefit from them for old and more or less
> stable code (e.g. RDMA-CM).
Sounds like a great approach to prevent new developers from contributing code.
You have to start somewhere and checkpatch patches are a good entry point for
such developers, discouraging them will only hurt us in the long term.
Linus had an interesting post on the subject:
https://lkml.org/lkml/2004/12/20/255
next prev parent reply other threads:[~2019-12-12 12:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 11:16 [PATCH] RDMA/cma: Fix checkpatch error Max Hirsch
2019-12-11 16:26 ` Jason Gunthorpe
2019-12-12 1:33 ` Max Hirsch
2019-12-18 12:52 ` Jason Gunthorpe
2019-12-12 8:49 ` Leon Romanovsky
2019-12-12 12:10 ` Gal Pressman [this message]
2019-12-12 12:28 ` Max Hirsch
2019-12-12 13:47 ` Leon Romanovsky
2019-12-12 13:41 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5123cbb-9871-d9c3-62e9-5b3172d1adf8@amazon.com \
--to=galpress@amazon.com \
--cc=bvanassche@acm.org \
--cc=dag.moxnes@oracle.com \
--cc=danitg@mellanox.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=max.hirsch@gmail.com \
--cc=mhjungk@gmail.com \
--cc=parav@mellanox.com \
--cc=swise@opengridcomputing.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).