From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54AE5C6FA99 for ; Thu, 23 Feb 2023 20:42:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbjBWUmC (ORCPT ); Thu, 23 Feb 2023 15:42:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbjBWUmA (ORCPT ); Thu, 23 Feb 2023 15:42:00 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45BF360129; Thu, 23 Feb 2023 12:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677184910; x=1708720910; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=QYtWiziCNJFTwuqjw+jdZbD6GHrBqdHN07ZRiLxTuts=; b=A9P7q+LqgSuvsZ0m6xzFKbqzREr4XVf5DCxRXtSxLp5e8BFQGvKIVzC+ OxUd20YOUIUi1WhxBr36PTm4jnve9i9DA4iuWerXuR9WXat5uKs7g6LD6 wXBatGyz/isFj7e/KRTojXeX9TO0cLKWM77BrPbRTOhQpduBMvlc+IbNH Kq0evlaF/R0IB387sn9/Q6ILlrhRbTdDHJTUY8ksf6RvT9OjSpcLqCqDy pTwEEFYQ5dlwVXtrjr42LWOjAvxm/w9NmrZnL17iPpmJZjglXXfthI2Ss EUKUuAWFMO23VZhBj4G8kAE24PhriYjipIE5fxVSwv6rZq31yLF9D8Pf/ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10630"; a="313707200" X-IronPort-AV: E=Sophos;i="5.97,322,1669104000"; d="scan'208";a="313707200" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2023 12:41:49 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10630"; a="672649594" X-IronPort-AV: E=Sophos;i="5.97,322,1669104000"; d="scan'208";a="672649594" Received: from bhouse-desk.amr.corp.intel.com (HELO [10.255.229.193]) ([10.255.229.193]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2023 12:41:48 -0800 Message-ID: Date: Thu, 23 Feb 2023 12:41:47 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v5 06/14] x86/ioremap: Support hypervisor specified range to map as encrypted Content-Language: en-US To: Sean Christopherson , "Michael Kelley (LINUX)" Cc: Borislav Petkov , "hpa@zytor.com" , KY Srinivasan , Haiyang Zhang , "wei.liu@kernel.org" , Dexuan Cui , "luto@kernel.org" , "peterz@infradead.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "lpieralisi@kernel.org" , "robh@kernel.org" , "kw@linux.com" , "bhelgaas@google.com" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "thomas.lendacky@amd.com" , "brijesh.singh@amd.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , Tianyu Lan , "kirill.shutemov@linux.intel.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "ak@linux.intel.com" , "isaku.yamahata@intel.com" , "dan.j.williams@intel.com" , "jane.chu@oracle.com" , "tony.luck@intel.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-arch@vger.kernel.org" , "iommu@lists.linux.dev" References: <4216dea6-d899-aecb-2207-caa2ae7db0e3@intel.com> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/23/23 12:26, Dave Hansen wrote: >> + if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)) { >> + /* >> + * Ensure fixmaps for IOAPIC MMIO respect memory encryption pgprot >> + * bits, just like normal ioremap(): >> + */ >> + if (x86_platform.hyper.is_private_mmio(phys)) >> + flags = pgprot_encrypted(flags); >> + else >> + flags = pgprot_decrypted(flags); >> + } ... > It does seem a bit odd that there's a new CC_ATTR_GUEST_MEM_ENCRYPT > check wrapping this whole thing. I guess the trip through > pgprot_decrypted() is harmless on normal platforms, though. Yeah, that's _really_ odd. Sean, were you trying to optimize away the indirect call or something? I would just expect the Hyper-V/vTOM code to leave x86_platform.hyper.is_private_mmio alone unless it *knows* the platform has private MMIO *and* CC_ATTR_GUEST_MEM_ENCRYPT. Is there ever a case where CC_ATTR_GUEST_MEM_ENCRYPT==0 and he Hyper-V/vTOM code would need to set x86_platform.hyper.is_private_mmio?