From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C62C433DF for ; Thu, 14 May 2020 01:33:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 127BB205CB for ; Thu, 14 May 2020 01:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728413AbgENBdB (ORCPT ); Wed, 13 May 2020 21:33:01 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:4840 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725925AbgENBdA (ORCPT ); Wed, 13 May 2020 21:33:00 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 21B6A29B7E58DFE8DD60; Thu, 14 May 2020 09:32:58 +0800 (CST) Received: from [127.0.0.1] (10.74.149.191) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Thu, 14 May 2020 09:32:51 +0800 Subject: Re: [PATCH net-next] net: phy: realtek: add loopback support for RTL8211F To: Andrew Lunn CC: , , , , , , , , Yufeng Mo , Jian Shen References: <1589358344-14009-1-git-send-email-tanhuazhong@huawei.com> <20200513131226.GA499265@lunn.ch> From: tanhuazhong Message-ID: Date: Thu, 14 May 2020 09:32:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20200513131226.GA499265@lunn.ch> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.74.149.191] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/5/13 21:12, Andrew Lunn wrote: > On Wed, May 13, 2020 at 04:25:44PM +0800, Huazhong Tan wrote: >> From: Yufeng Mo >> >> PHY loopback is already supported by genphy driver. This patch >> adds the set_loopback interface to RTL8211F PHY driver, so the PHY >> selftest can run properly on it. >> >> Signed-off-by: Yufeng Mo >> Signed-off-by: Jian Shen >> Signed-off-by: Huazhong Tan > > It took three people to write a 1 line patch? Yufeng Mo is the author of this patch, since he has not right to send mail so I just help him to do than。 If necessary, Jian Shen could be deleted. > >> --- >> drivers/net/phy/realtek.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c >> index c7229d0..6c5918c 100644 >> --- a/drivers/net/phy/realtek.c >> +++ b/drivers/net/phy/realtek.c >> @@ -615,6 +615,7 @@ static struct phy_driver realtek_drvs[] = { >> .resume = genphy_resume, >> .read_page = rtl821x_read_page, >> .write_page = rtl821x_write_page, >> + .set_loopback = genphy_loopback, >> }, { >> .name = "Generic FE-GE Realtek PHY", >> .match_phy_device = rtlgen_match_phy_device, > > Do you have access to the data sheets? Can you check if the other PHYs > supported by this driver also support loopback in the standard way? > They probably do. > > Andrew > We have checked the data sheet. Since we only have rtl8211f phy on our hand, so only support loopback on this phy. Thanks:) > . >