From: Roger Quadros <rogerq@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: krzysztof.kozlowski@canonical.com, tony@atomide.com,
kishon@ti.com, nm@ti.com, vigneshr@ti.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/4] memory: omap-gpmc: check for nand node name instead of just compatibility
Date: Fri, 17 Dec 2021 09:35:20 +0200 [thread overview]
Message-ID: <e54729b3-0a72-a217-b320-b81c1f90d3f9@kernel.org> (raw)
In-Reply-To: <YboRyR+SqBV03cY0@robh.at.kernel.org>
Hi Rob,
On 15/12/2021 18:03, Rob Herring wrote:
> On Wed, Dec 08, 2021 at 02:46:10PM +0200, Roger Quadros wrote:
>> We have added new compatibles for controller so just checking for
>> "ti,omap2-nand" compatible is not enough. Check for "nand" node name
>> as well.
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
>> ---
>> drivers/memory/omap-gpmc.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
>> index 624153048182..9f0062a262db 100644
>> --- a/drivers/memory/omap-gpmc.c
>> +++ b/drivers/memory/omap-gpmc.c
>> @@ -2183,7 +2183,8 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
>> }
>> }
>>
>> - if (of_device_is_compatible(child, "ti,omap2-nand")) {
>> + if (of_device_is_compatible(child, "ti,omap2-nand") ||
>> + of_node_name_eq(child, "nand")) {
>
> It would be better to stick with compatible strings. You can match
> against a match table. This should be 'nand-controller' really if this
> binding had a proper split between the controller and nand chips.
OK. I will change this to use compatible strings using a match table.
The 'nand-controller' + 'nand' chip change will be done in a separate series
sometime later.
cheers,
-roger
next prev parent reply other threads:[~2021-12-17 7:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 12:46 [PATCH v2 1/4] dt-bindings: memory-controllers: ti,gpmc: Add compatible for AM64 Roger Quadros
2021-12-08 12:46 ` [PATCH v2 2/4] memory: omap-gpmc: Add support for GPMC on AM64 SoC Roger Quadros
2021-12-08 12:46 ` [PATCH v2 3/4] memory: omap-gpmc: check for nand node name instead of just compatibility Roger Quadros
2021-12-15 16:03 ` Rob Herring
2021-12-17 7:35 ` Roger Quadros [this message]
2021-12-08 12:46 ` [PATCH v2 4/4] arm64: arch_k3: Select GPMC device driver Roger Quadros
2021-12-15 16:03 ` [PATCH v2 1/4] dt-bindings: memory-controllers: ti,gpmc: Add compatible for AM64 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e54729b3-0a72-a217-b320-b81c1f90d3f9@kernel.org \
--to=rogerq@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).