From: Carsten Haitzler <carsten.haitzler@foss.arm.com>
To: James Clark <james.clark@arm.com>, linux-kernel@vger.kernel.org
Cc: coresight@lists.linaro.org, mathieu.poirier@linaro.org,
mike.leach@linaro.org, linux-perf-users@vger.kernel.org,
acme@kernel.org, Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: Re: [PATCH 10/14] perf test: Add thread loop test shell scripts
Date: Fri, 8 Jul 2022 10:21:59 +0100 [thread overview]
Message-ID: <e55094af-557e-8044-fc14-00189bd392a2@foss.arm.com> (raw)
In-Reply-To: <a14e7015-7446-8cb3-612c-00dcb469c939@arm.com>
On 7/5/22 14:53, James Clark wrote:
>
>
> On 01/07/2022 13:07, carsten.haitzler@foss.arm.com wrote:
>> From: "Carsten Haitzler (Rasterman)" <raster@rasterman.com>
>>
>> Add a script to drive the thread loop test that gathers data so
>> it passes a minimum bar (in this case do we get any perf context data
>> for every thread).
>>
>> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
>
> Hi Carsten,
>
> I checked this on N1SDP and I get failures in both threads tests. This is
> because it's looking for "CID=..." when in my output threads are shown as
> "VMID=...":
>
> Idx:628048; ID:10; I_ADDR_CTXT_L_64IS0 : Address & Context, Long, 64 bit, IS0.; Addr=0x0000AAAAE3BF0B18; Ctxt: AArch64,EL0, NS; VMID=0xa588c;
>
> I think with a change to the grep it should work.
Errrr... I get no VMID= ... it's all
Idx:563008; ID:12; I_ADDR_CTXT_L_64IS0 : Address & Context, Long, 64
bit, IS0.; Addr=0x0000AAAAE4B00A60; Ctxt: AArch64,EL0, NS; CID=0x00004aff;
are you using containers or something? because:
if(context.updated_c)
{
oss << "CID=0x" << std::hex << std::setfill('0') <<
std::setw(8) << context.ctxtID << "; ";
}
if(context.updated_v)
{
oss << "VMID=0x" << std::hex << std::setfill('0') <<
std::setw(4) << context.VMID << "; ";
}
I'm running without any containers etc. - bare metal. Haven't bothered
with any VM stuff.
In OpenOCD the CID should be the the pid/thread id. It seems to not be
the same thing as VMID. I haven't traced this beyond here as to exactly
what this represents though my first reaction is "This is extra VM info
and not the PID/TID being looked for". OpenOCD is full of tests with log
dumps that produce CID and VMID:
Idx:1676; ID:10; I_ADDR_CTXT_L_64IS0 : Address & Context, Long,
64 bit, IS0.; Addr=0xFFFFFFC000096A00; Ctxt: AArch64,EL1, NS;
CID=0x00000000; VMID=0x0000;
A quick git grep CID= in OpenCD will show them all. My understanding is
CID is the thread/process ID and thus the test/check "Do we get reported
data from all threads? - anything?".
I don't think using VMID is right. The fact you are missing a CID is an
issue though...
> Thanks
> James
>
>> ---
>> .../coresight/thread_loop_check_tid_10.sh | 19 +++++++++++++++++++
>> .../coresight/thread_loop_check_tid_2.sh | 19 +++++++++++++++++++
>> 2 files changed, 38 insertions(+)
>> create mode 100755 tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh
>> create mode 100755 tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh
>>
>> diff --git a/tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh b/tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh
>> new file mode 100755
>> index 000000000000..7c13636fc778
>> --- /dev/null
>> +++ b/tools/perf/tests/shell/coresight/thread_loop_check_tid_10.sh
>> @@ -0,0 +1,19 @@
>> +#!/bin/sh -e
>> +# CoreSight / Thread Loop 10 Threads - Check TID
>> +
>> +# SPDX-License-Identifier: GPL-2.0
>> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
>> +
>> +TEST="thread_loop"
>> +. $(dirname $0)/../lib/coresight.sh
>> +ARGS="10 1"
>> +DATV="check-tid-10th"
>> +DATA="$DATD/perf-$TEST-$DATV.data"
>> +STDO="$DATD/perf-$TEST-$DATV.stdout"
>> +
>> +SHOW_TID=1 perf record -s $PERFRECOPT -o "$DATA" "$BIN" $ARGS > $STDO
>> +
>> +perf_dump_aux_tid_verify "$DATA" "$STDO"
>> +
>> +err=$?
>> +exit $err
>> diff --git a/tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh b/tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh
>> new file mode 100755
>> index 000000000000..a067145af43c
>> --- /dev/null
>> +++ b/tools/perf/tests/shell/coresight/thread_loop_check_tid_2.sh
>> @@ -0,0 +1,19 @@
>> +#!/bin/sh -e
>> +# CoreSight / Thread Loop 2 Threads - Check TID
>> +
>> +# SPDX-License-Identifier: GPL-2.0
>> +# Carsten Haitzler <carsten.haitzler@arm.com>, 2021
>> +
>> +TEST="thread_loop"
>> +. $(dirname $0)/../lib/coresight.sh
>> +ARGS="2 20"
>> +DATV="check-tid-2th"
>> +DATA="$DATD/perf-$TEST-$DATV.data"
>> +STDO="$DATD/perf-$TEST-$DATV.stdout"
>> +
>> +SHOW_TID=1 perf record -s $PERFRECOPT -o "$DATA" "$BIN" $ARGS > $STDO
>> +
>> +perf_dump_aux_tid_verify "$DATA" "$STDO"
>> +
>> +err=$?
>> +exit $err
next prev parent reply other threads:[~2022-07-08 9:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 12:07 Patch series to add to and imporve tests for CoreSight carsten.haitzler
2022-07-01 12:07 ` [PATCH 01/14] perf test: Refactor shell tests allowing subdirs carsten.haitzler
2022-07-01 12:07 ` [PATCH 02/14] perf test: Add CoreSight shell lib shared code for future tests carsten.haitzler
2022-07-01 12:07 ` [PATCH 03/14] perf test: Add build infra for perf test tools for CoreSight tests carsten.haitzler
2022-07-01 12:07 ` [PATCH 04/14] perf test: Add asm pureloop test tool carsten.haitzler
2022-07-01 12:07 ` [PATCH 05/14] perf test: Add asm pureloop test shell script carsten.haitzler
2022-07-01 12:07 ` [PATCH 06/14] perf test: Add git ignore for perf data generated by the CoreSight tests carsten.haitzler
2022-07-01 12:07 ` [PATCH 07/14] perf test: Add memcpy thread test tool carsten.haitzler
2022-07-01 12:07 ` [PATCH 08/14] perf test: Add memcpy thread test shell script carsten.haitzler
2022-07-05 14:25 ` James Clark
2022-07-05 14:28 ` James Clark
2022-07-08 9:19 ` Carsten Haitzler
2022-07-01 12:07 ` [PATCH 09/14] perf test: Add thread loop test tool carsten.haitzler
2022-07-01 12:07 ` [PATCH 10/14] perf test: Add thread loop test shell scripts carsten.haitzler
2022-07-05 13:53 ` James Clark
2022-07-08 9:21 ` Carsten Haitzler [this message]
2022-07-08 10:27 ` Mike Leach
2022-07-08 16:45 ` Carsten Haitzler
2022-07-01 12:08 ` [PATCH 11/14] perf test: Add unroll thread test tool carsten.haitzler
2022-07-01 12:08 ` [PATCH 12/14] perf test: Add unroll thread test shell script carsten.haitzler
2022-07-01 12:08 ` [PATCH 13/14] perf test: Add git ignore for tmp and output files of CoreSight tests carsten.haitzler
2022-07-01 12:08 ` [PATCH 14/14] perf test: Add relevant documentation about CoreSight testing carsten.haitzler
2022-07-02 3:02 ` Bagas Sanjaya
2022-07-08 9:27 ` Carsten Haitzler
2022-07-08 10:43 ` Mike Leach
2022-07-05 22:41 ` kernel test robot
2022-07-12 13:57 A patch series improving data quality of perf test for CoreSight carsten.haitzler
2022-07-12 13:57 ` [PATCH 10/14] perf test: Add thread loop test shell scripts carsten.haitzler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e55094af-557e-8044-fc14-00189bd392a2@foss.arm.com \
--to=carsten.haitzler@foss.arm.com \
--cc=acme@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=james.clark@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).