From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F105C4CEC4 for ; Wed, 18 Sep 2019 15:15:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E346D218AE for ; Wed, 18 Sep 2019 15:15:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731551AbfIRPPk (ORCPT ); Wed, 18 Sep 2019 11:15:40 -0400 Received: from mga14.intel.com ([192.55.52.115]:29252 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727968AbfIRPPk (ORCPT ); Wed, 18 Sep 2019 11:15:40 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 08:15:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,521,1559545200"; d="scan'208";a="338355937" Received: from linux.intel.com ([10.54.29.200]) by orsmga004.jf.intel.com with ESMTP; 18 Sep 2019 08:15:38 -0700 Received: from pbossart-mac01.local (unknown [10.251.11.91]) by linux.intel.com (Postfix) with ESMTP id C90925802B0; Wed, 18 Sep 2019 08:15:37 -0700 (PDT) Subject: Re: [alsa-devel] [RFC PATCH 8/9] soundwire: intel: remove platform devices and provide new interface To: Greg KH Cc: alsa-devel@alsa-project.org, tiwai@suse.de, linux-kernel@vger.kernel.org, Ranjani Sridharan , vkoul@kernel.org, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Bard liao , Rander Wang References: <20190916212342.12578-1-pierre-louis.bossart@linux.intel.com> <20190916212342.12578-9-pierre-louis.bossart@linux.intel.com> <20190917055512.GE2058532@kroah.com> <20190918120629.GD1901208@kroah.com> <20190918135302.GA1919118@kroah.com> <20190918135431.GA1919350@kroah.com> From: Pierre-Louis Bossart Message-ID: Date: Wed, 18 Sep 2019 10:14:51 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20190918135431.GA1919350@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/18/19 8:54 AM, Greg KH wrote: > On Wed, Sep 18, 2019 at 03:53:02PM +0200, Greg KH wrote: >> On Wed, Sep 18, 2019 at 08:48:33AM -0500, Pierre-Louis Bossart wrote: >>> On 9/18/19 7:06 AM, Greg KH wrote: >>>> On Tue, Sep 17, 2019 at 09:29:52AM -0500, Pierre-Louis Bossart wrote: >>>>> On 9/17/19 12:55 AM, Greg KH wrote: >>>>>> On Mon, Sep 16, 2019 at 04:23:41PM -0500, Pierre-Louis Bossart wrote: >>>>>>> +/** >>>>>>> + * sdw_intel_probe() - SoundWire Intel probe routine >>>>>>> + * @parent_handle: ACPI parent handle >>>>>>> + * @res: resource data >>>>>>> + * >>>>>>> + * This creates SoundWire Master and Slave devices below the controller. >>>>>>> + * All the information necessary is stored in the context, and the res >>>>>>> + * argument pointer can be freed after this step. >>>>>>> + */ >>>>>>> +struct sdw_intel_ctx >>>>>>> +*sdw_intel_probe(struct sdw_intel_res *res) >>>>>>> +{ >>>>>>> + return sdw_intel_probe_controller(res); >>>>>>> +} >>>>>>> +EXPORT_SYMBOL(sdw_intel_probe); >>>>>>> + >>>>>>> +/** >>>>>>> + * sdw_intel_startup() - SoundWire Intel startup >>>>>>> + * @ctx: SoundWire context allocated in the probe >>>>>>> + * >>>>>>> + */ >>>>>>> +int sdw_intel_startup(struct sdw_intel_ctx *ctx) >>>>>>> +{ >>>>>>> + return sdw_intel_startup_controller(ctx); >>>>>>> +} >>>>>>> +EXPORT_SYMBOL(sdw_intel_startup); >>>>>> >>>>>> Why are you exporting these functions if no one calls them? >>>>> >>>>> They are used in the next series, see '[RFC PATCH 04/12] ASoC: SOF: Intel: >>>>> add SoundWire configuration interface' >>>> >>>> That wasn't obvious :) >>>> >>>> Also, why not EXPORT_SYMBOL_GPL()? :) >>> >>> Since the beginning of this SoundWire work, the intent what that the code >>> could be reused in non-GPL open-source circles, hence the dual license and >>> EXPORT_SYMBOL. >> >> Hah, you _have_ talked to your lawyers about this, right? >> >> You have a chance to do something like this for header files, for .c >> files, good luck. That's going to be a hard road to go down. Many have >> tried in the past, all but 1 have failed. > > Also note, the last I checked, the _default_ license for Linux kernel > code from Intel was GPLv2. If you got an exception for this, please > work with your legal council on how to do this "properly" as that was > part of getting that exception, right? > > If you didn't get the exception, um, you have some people to go talk to, > and how come I am the one asking you about this? :( All the legal due-diligence was done when SoundWire was initially contributed in 2018. You asked that question at the time and I will point you to the email exchange Alan Cox and you had on this topic [1]. [1] https://patchwork.kernel.org/patch/10015813/