linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Jan Kara <jack@suse.cz>
Cc: Jan Kara <jack@suse.com>, linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] quota: remove unnecessary oom message
Date: Fri, 18 Jun 2021 09:20:34 +0800	[thread overview]
Message-ID: <e56de5db-9b76-6d24-68c9-0acb3776c9e8@huawei.com> (raw)
In-Reply-To: <20210617150116.GG32587@quack2.suse.cz>



On 2021/6/17 23:01, Jan Kara wrote:
> On Thu 17-06-21 17:16:27, Zhen Lei wrote:
>> Fixes scripts/checkpatch.pl warning:
>> WARNING: Possible unnecessary 'out of memory' message
>>
>> Remove it can help us save a bit of memory.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
> 
> I agree the message is pointless. But when doing this, I guess we can just
> get rid of getdqbuf() altogether and instead call kmalloc() directly in all
> the places.

OK, I will get rid of it in v2.

> 
> 								Honza
> 
>> diff --git a/fs/quota/quota_tree.c b/fs/quota/quota_tree.c
>> index c5562c871c8b..b097d02bad94 100644
>> --- a/fs/quota/quota_tree.c
>> +++ b/fs/quota/quota_tree.c
>> @@ -49,11 +49,7 @@ static int qtree_dqstr_in_blk(struct qtree_mem_dqinfo *info)
>>  
>>  static char *getdqbuf(size_t size)
>>  {
>> -	char *buf = kmalloc(size, GFP_NOFS);
>> -	if (!buf)
>> -		printk(KERN_WARNING
>> -		       "VFS: Not enough memory for quota buffers.\n");
>> -	return buf;
>> +	return kmalloc(size, GFP_NOFS);
>>  }
>>  
>>  static ssize_t read_blk(struct qtree_mem_dqinfo *info, uint blk, char *buf)
>> -- 
>> 2.25.1
>>
>>


      reply	other threads:[~2021-06-18  1:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  9:16 Zhen Lei
2021-06-17 15:01 ` Jan Kara
2021-06-18  1:20   ` Leizhen (ThunderTown) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e56de5db-9b76-6d24-68c9-0acb3776c9e8@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=jack@suse.com \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/1] quota: remove unnecessary oom message' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).