From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F2BC2B9F4 for ; Fri, 18 Jun 2021 01:20:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1087F6135C for ; Fri, 18 Jun 2021 01:20:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233533AbhFRBWr (ORCPT ); Thu, 17 Jun 2021 21:22:47 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:4961 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232000AbhFRBWq (ORCPT ); Thu, 17 Jun 2021 21:22:46 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G5gyF1XH7z6yLJ; Fri, 18 Jun 2021 09:17:25 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 18 Jun 2021 09:20:36 +0800 Received: from [127.0.0.1] (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 18 Jun 2021 09:20:35 +0800 Subject: Re: [PATCH 1/1] quota: remove unnecessary oom message To: Jan Kara CC: Jan Kara , linux-kernel References: <20210617091627.1653-1-thunder.leizhen@huawei.com> <20210617150116.GG32587@quack2.suse.cz> From: "Leizhen (ThunderTown)" Message-ID: Date: Fri, 18 Jun 2021 09:20:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20210617150116.GG32587@quack2.suse.cz> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/17 23:01, Jan Kara wrote: > On Thu 17-06-21 17:16:27, Zhen Lei wrote: >> Fixes scripts/checkpatch.pl warning: >> WARNING: Possible unnecessary 'out of memory' message >> >> Remove it can help us save a bit of memory. >> >> Signed-off-by: Zhen Lei > > I agree the message is pointless. But when doing this, I guess we can just > get rid of getdqbuf() altogether and instead call kmalloc() directly in all > the places. OK, I will get rid of it in v2. > > Honza > >> diff --git a/fs/quota/quota_tree.c b/fs/quota/quota_tree.c >> index c5562c871c8b..b097d02bad94 100644 >> --- a/fs/quota/quota_tree.c >> +++ b/fs/quota/quota_tree.c >> @@ -49,11 +49,7 @@ static int qtree_dqstr_in_blk(struct qtree_mem_dqinfo *info) >> >> static char *getdqbuf(size_t size) >> { >> - char *buf = kmalloc(size, GFP_NOFS); >> - if (!buf) >> - printk(KERN_WARNING >> - "VFS: Not enough memory for quota buffers.\n"); >> - return buf; >> + return kmalloc(size, GFP_NOFS); >> } >> >> static ssize_t read_blk(struct qtree_mem_dqinfo *info, uint blk, char *buf) >> -- >> 2.25.1 >> >>