On 9/17/20 4:00 AM, Mark Brown wrote:
> On Thu, Sep 17, 2020 at 12:18:19PM +0200, Alban Bedel wrote:
> 
>> +	data->vs = devm_regulator_get_optional(dev, "vs");
>> +	if (IS_ERR(data->vs)) {
> 
> Unless the device can work without power you should not be using
> regulator_get_optional().
> 

The driver works today without regulator, and needs to continue
doing so.

Guenter