From: Derek Dolney <z23@posteo.net>
To: Peter Zijlstra <peterz@infradead.org>,
Vincent Donnefort <vdonnefort@google.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
vschneid@redhat.com, kernel-team@android.com
Subject: Re: [PATCH v2] cpu/hotplug: Do not bail-out in DYING/STARTING sections
Date: Sun, 29 May 2022 18:01:14 +0000 [thread overview]
Message-ID: <e589b71b-9fa2-0ca1-af2e-0c513b9250cd@posteo.net> (raw)
In-Reply-To: <20220526101536.GP2578@worktop.programming.kicks-ass.net>
FYI there is also now a patch to fix the driver bug in testing by the
tboot devs at the moment, you could monitor the progress here:
https://sourceforge.net/p/tboot/mailman/message/37659164/
I tested this patch and it works for me.
Derek
On 5/26/22 6:15 AM, Peter Zijlstra wrote:
> On Thu, May 26, 2022 at 09:24:28AM +0100, Vincent Donnefort wrote:
>> On Wed, May 25, 2022 at 06:52:48PM +0200, Peter Zijlstra wrote:
>>> On Mon, May 23, 2022 at 05:05:36PM +0100, Vincent Donnefort wrote:
>>>> The DYING/STARTING callbacks are not expected to fail. However, as reported
>>>> by Derek, drivers such as tboot are still free to return errors within
>>>> those sections. In that case, there's nothing the hotplug machinery can do,
>>>> so let's just proceed and log the failures.
>>>>
>>>
>>> I'm confused. Why isn't this a driver bug?
>>
>> It is a entirely a driver bug which has been reported already. but 453e41085183
>> (cpu/hotplug: Add cpuhp_invoke_callback_range()) changed the behaviour so I
>> thought it would be worth to revert to the original one which is to not break
>> the entire up/down for a single driver error.
>
> Ah I see. Fair enough I suppose.
>
next prev parent reply other threads:[~2022-05-29 18:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 16:05 [PATCH v2] cpu/hotplug: Do not bail-out in DYING/STARTING sections Vincent Donnefort
2022-05-25 16:52 ` Peter Zijlstra
2022-05-26 8:24 ` Vincent Donnefort
2022-05-26 10:15 ` Peter Zijlstra
2022-05-29 18:01 ` Derek Dolney [this message]
2022-05-26 11:48 ` Derek Dolney
2022-05-26 12:27 ` Derek Dolney
2022-06-13 12:36 ` Thomas Gleixner
2022-06-13 13:37 ` Vincent Donnefort
2022-07-04 10:01 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e589b71b-9fa2-0ca1-af2e-0c513b9250cd@posteo.net \
--to=z23@posteo.net \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vdonnefort@google.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).