From: YueHaibing <yuehaibing@huawei.com>
To: Caio Salvador Rohwedder <caiosalvador96@gmail.com>,
<gregkh@linuxfoundation.org>
Cc: <johnfwhitmore@gmail.com>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>, <lkcamp@lists.libreplanetbr.org>
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: add space around '==' and before '('
Date: Fri, 5 Apr 2019 10:31:17 +0800 [thread overview]
Message-ID: <e595121b-81f1-8242-eb91-a9258b96831d@huawei.com> (raw)
In-Reply-To: <20190405015646.20672-1-caiosalvador96@gmail.com>
On 2019/4/5 9:56, Caio Salvador Rohwedder wrote:
> Fix checkpatch coding style errors on rtl819x_TSProc.c
> - space required before the open parenthesis '('
> - spaces required around that '=='
>
> Signed-off-by: Caio Salvador Rohwedder <caiosalvador96@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> index c76715ffa08b..0af1a87a5545 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> @@ -373,7 +373,7 @@ bool GetTs(
> if(!list_empty(pUnusedList)) {
> (*ppTS) = list_entry(pUnusedList->next, struct ts_common_info, list);
> list_del_init(&(*ppTS)->list);
> - if(TxRxSelect==TX_DIR) {
> + if (TxRxSelect == TX_DIR) {
> struct tx_ts_record *tmp = container_of(*ppTS, struct tx_ts_record, ts_common_info);
This line seems over 80 characters, may also be fixed.
In fact, this file has so many code style issues, see
./scripts/checkpatch.pl --no-tree -f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
> ResetTxTsEntry(tmp);
> } else {
>
next prev parent reply other threads:[~2019-04-05 2:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 1:56 [PATCH] staging: rtl8192u: ieee80211: add space around '==' and before '(' Caio Salvador Rohwedder
2019-04-05 2:31 ` YueHaibing [this message]
2019-04-05 5:11 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e595121b-81f1-8242-eb91-a9258b96831d@huawei.com \
--to=yuehaibing@huawei.com \
--cc=caiosalvador96@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).