From: Loic Pallardy <loic.pallardy@st.com>
To: <bjorn.andersson@linaro.org>, <ohad@wizery.com>, <lee.jones@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <patrice.chotard@st.com>,
<hugues.fruchet@st.com>
Subject: Re: [PATCH v4 0/5] virtio_rpmsg: make rpmsg channel configurable
Date: Wed, 3 May 2017 17:34:09 +0200 [thread overview]
Message-ID: <e599dcbd-a218-660d-39cc-9dd777f80d51@st.com> (raw)
In-Reply-To: <1490701787-15205-1-git-send-email-loic.pallardy@st.com>
On 03/28/2017 01:49 PM, Loic Pallardy wrote:
> This goal of this series is to offer more flexibility for virtio_rpmsg
> communication link configuration.
>
> It should be possible to tune rpmsg buffer size per Rpmsg link, to provide
> selected configuration to coprocessor, to take into account coprocessor
> specificities like memory region.
>
> This series introduces an optional virtio rpmsg configuration structure, which
> will be managed as an extension of struct fw_rsc_vdev present in coprocessor firmware
> resource table.
> Structure access is possible thanks to virtio get and set API.
> This structure contains the different information to tune the link between the
> host and the coprocessor.
>
> Patch "rpmsg: virtio_rpmsg_bus: fix sg_set_buf() when addr is not a valid
> kernel address" has the same goal as Wendy's RFC [1]. I don't have tested
> Wendy's series with level driver buffer allocation.
>
> Last patch "rpmsg: virtio_rpmsg: set buffer configuration to virtio" has a
> dependency with remoteproc subdevice boot sequence as coprocessor resource
> table must be updated before coprocessor start. See [2]
>
> [1] http://www.spinics.net/lists/linux-remoteproc/msg00852.html
> [2] http://www.spinics.net/lists/linux-remoteproc/msg00826.html
>
> ---
> Changes from v1:
> - No more dependency with [2]. Coprocessor firmware should wait for first kick
> indicating virtio rpmsg link ready before accessing resource table information.
> - Correct issues reported by Suman
> - Fix warnings found by checkpatch with --strict option
>
> Changes from v2:
> - Fix warnings reported by kbuild test robot
>
> Changes from v3:
> After discussions with Bjorn, virtual address sharing between low level driver
> and virtio_rpmsg could be replaced by associated a dedicated memory region to
> vdev and changing virtio_rpmsg allocation from dev->parent->parent to
> dev->parent, i.e. vdev and not rproc device.
> The advantage of the solution is that there will be only few changes in
> virtio_rpmsg layer and it will be common with virtio_console driver.
> These will be part of a dedicated patch series.
> So v4 drops previous patch 5 "rpmsg: virtio_rpmsg: don't allocate buffer if
> provided by low level driver" dealing with buffer previously allocated and va
> fields from struct virtio_rpmsg_cfg.
> In addition, patch series has been rebased on kernel 4.11-rc4.
>
Hi Bjorn,
Any time to review this series?
Regards,
Loic
>
> Loic Pallardy (5):
> rpmsg: virtio_rpmsg: set rpmsg_buf_size customizable
> rpmsg: virtio_rpmsg_bus: fix sg_set_buf() when addr is not a valid
> kernel address
> include: virtio_rpmsg: add virtio rpmsg configuration structure
> rpmsg: virtio_rpmsg: get buffer configuration from virtio
> rpmsg: virtio_rpmsg: set buffer configuration to virtio
>
> drivers/rpmsg/virtio_rpmsg_bus.c | 123 +++++++++++++++++++++++++++++++++----
> include/linux/rpmsg/virtio_rpmsg.h | 30 +++++++++
> 2 files changed, 141 insertions(+), 12 deletions(-)
> create mode 100644 include/linux/rpmsg/virtio_rpmsg.h
>
prev parent reply other threads:[~2017-05-03 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 11:49 [PATCH v4 0/5] virtio_rpmsg: make rpmsg channel configurable Loic Pallardy
2017-03-28 11:49 ` [PATCH v4 1/5] rpmsg: virtio_rpmsg: set rpmsg_buf_size customizable Loic Pallardy
2017-05-26 16:24 ` Suman Anna
2017-03-28 11:49 ` [PATCH v4 2/5] rpmsg: virtio_rpmsg_bus: fix sg_set_buf() when addr is not a valid kernel address Loic Pallardy
2017-08-24 22:03 ` Suman Anna
2017-03-28 11:49 ` [PATCH v4 3/5] include: virtio_rpmsg: add virtio rpmsg configuration structure Loic Pallardy
2017-03-28 11:49 ` [PATCH v4 4/5] rpmsg: virtio_rpmsg: get buffer configuration from virtio Loic Pallardy
2017-03-28 11:49 ` [PATCH v4 5/5] rpmsg: virtio_rpmsg: set buffer configuration to virtio Loic Pallardy
2017-05-03 15:34 ` Loic Pallardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e599dcbd-a218-660d-39cc-9dd777f80d51@st.com \
--to=loic.pallardy@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=hugues.fruchet@st.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).