From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9DB1C433DB for ; Sun, 24 Jan 2021 15:08:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78CC422B2C for ; Sun, 24 Jan 2021 15:08:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726163AbhAXPIH (ORCPT ); Sun, 24 Jan 2021 10:08:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725880AbhAXPID (ORCPT ); Sun, 24 Jan 2021 10:08:03 -0500 Received: from relay08.th.seeweb.it (relay08.th.seeweb.it [IPv6:2001:4b7a:2000:18::169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5B83C061574 for ; Sun, 24 Jan 2021 07:07:22 -0800 (PST) Received: from [192.168.1.101] (abaf224.neoplus.adsl.tpnet.pl [83.6.169.224]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id AE0EE3EC75; Sun, 24 Jan 2021 16:07:20 +0100 (CET) Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8916-longcheer-l8910: Add imu/magnetometer To: Jonathan Albrieux , linux-kernel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, stephan@gerhold.net, Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20210124135409.5473-1-jonathan.albrieux@gmail.com> <20210124135409.5473-4-jonathan.albrieux@gmail.com> From: Konrad Dybcio Message-ID: Date: Sun, 24 Jan 2021 16:07:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210124135409.5473-4-jonathan.albrieux@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +&blsp_i2c3 { > + status = "okay"; > + > + imu@68 { > + compatible = "bosch,bmi160"; > + reg = <0x68>; > + > + vdd-supply = <&pm8916_l17>; > + vddio-supply = <&pm8916_l6>; > + > + mount-matrix = "0", "1", "0", > + "-1", "0", "0", > + "0", "0", "1"; > + }; > + > + magnetometer@d { > + compatible = "asahi-kasei,ak09911"; > + reg = <0x0d>; > + > + vdd-supply = <&pm8916_l17>; > + vid-supply = <&pm8916_l6>; > + > + reset-gpios = <&msmgpio 111 GPIO_ACTIVE_LOW>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&mag_reset_default>; > + }; > +}; Please sort I2C devices by their address. > }; > > + mag_reset_default: mag-reset-default { > + pins = "gpio111"; > + function = "gpio"; > + > + drive-strength = <2>; > + bias-disable; > + }; > + Please add this after gpio110 to keep it sorted gpio-number-wise. Konrad