From: Jiri Slaby <jslaby@suse.cz>
To: Gen Zhang <blackgod016574@gmail.com>, Stephen Boyd <sboyd@kernel.org>
Cc: mturquette@baylibre.com, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: fix a missing-free bug in clk_cpy_name()
Date: Fri, 7 Jun 2019 11:10:37 +0200 [thread overview]
Message-ID: <e5b4639b-3077-59bb-6383-0c2bccdd9191@suse.cz> (raw)
In-Reply-To: <20190607015258.GA2660@zhanggen-UX430UQ>
On 07. 06. 19, 3:52, Gen Zhang wrote:
>>>>> @@ -3491,6 +3492,8 @@ static int clk_core_populate_parent_map(struct clk_core *core)
>>>>> kfree_const(parents[i].name);
>>>>> kfree_const(parents[i].fw_name);
>>>>> } while (--i >= 0);
>>>>> + kfree_const(parent->name);
>>>>> + kfree_const(parent->fw_name);
>>>>
>>>> Both of them were just freed in the loop above, no?
>>> for (i = 0, parent = parents; i < num_parents; i++, parent++)
>>> Is 'parent' the same as the one from the loop above?
>>
>> Yes. Did it change somehow?
> parent++?
parent++ is done after the loop body. Or what do you mean?
>>> Moreover, should 'parents[i].name' and 'parents[i].fw_name' be freed by
>>> kfree_const()?
>>>
>>
>> Yes? They're allocated with kstrdup_const() in clk_cpy_name(), or
>> they're NULL by virtue of the kcalloc and then kfree_const() does
>> nothing.
> I re-examined clk_cpy_name(). They are the second parameter of
> clk_cpy_name(). The first parameter is allocated, not the second one.
> So 'parent->name' and 'parent->fw_name' should be freed, not
> 'parents[i].name' or 'parents[i].fw_name'. Am I totally misunderstanding
> this clk_cpy_name()? :-(
The second parameter (the source) is parent_data[i].*, not parents[i].*
(the destination). parent->fw_name and parent->name are properly freed
in the do {} while loop as parents[i].name and parents[i].fw_name, given
i hasn't changed yet. I am not sure what you mean at all. Are you
uncertain about the C code flow?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2019-06-07 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 1:14 [PATCH] clk: fix a missing-free bug in clk_cpy_name() Gen Zhang
2019-06-05 6:38 ` Jiri Slaby
2019-06-05 16:00 ` Gen Zhang
2019-06-06 20:16 ` Stephen Boyd
2019-06-07 1:52 ` Gen Zhang
2019-06-07 9:10 ` Jiri Slaby [this message]
2019-06-07 12:07 ` Gen Zhang
-- strict thread matches above, loose matches on Subject: below --
2019-05-27 14:04 Gen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5b4639b-3077-59bb-6383-0c2bccdd9191@suse.cz \
--to=jslaby@suse.cz \
--cc=blackgod016574@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).