From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61987C2BA16 for ; Tue, 7 Apr 2020 08:15:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2B9C2206F5 for ; Tue, 7 Apr 2020 08:15:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q14xEyVQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727941AbgDGIPd (ORCPT ); Tue, 7 Apr 2020 04:15:33 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:34875 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbgDGIPc (ORCPT ); Tue, 7 Apr 2020 04:15:32 -0400 Received: by mail-ed1-f65.google.com with SMTP id c7so2947630edl.2 for ; Tue, 07 Apr 2020 01:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gYSBPF0kqvjFsMt96b7gq4l3LXMLVPqJ/kTyN1DMzC4=; b=Q14xEyVQtMB9EutZZR+8RRGK9Zf6kbBWZ940ZDnrulLNn06x2V6BdqqTY2KwOAjyB+ 1DdDvh7XDSL4+3ENES1jPazifAXGACgRDQvf0o+WckllB05VtC07VQtxp5jqxhZ6d/eR WeKjYa+zIP4PHVwh7H5LDDCwXUji2Fwa4ck0haiajLbrZDkCi5jtKF1hG3ufUc5eTZ8H 6m7ABzlJ52jurXp5oBrWaT1HUSbM050utDGxa3mSEyoxo+k5GV8pbgtpJWAeCZiOi9GZ yX8FHXHvMF9IZcCQCa+KgmcKzoSF61oPZXSv736Xf+ztL8g9HFRTcyVQfFmOUNuMmZA5 4AkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gYSBPF0kqvjFsMt96b7gq4l3LXMLVPqJ/kTyN1DMzC4=; b=R059YC56v3aApwYe50//eNqnK/naN2ofjFBCyUIMVV+wtecyIpyBlghkZmsN+JyNcP KBD66y5mNGDdqV3oPmFD3HOEiCgblhKx3EPekfXpjmuPGDJmn+idjWZTtEqbkvjZztbd gOzoQSXepjx74+lJqrVoZQcbOdlOYFNWdQQeMWw3O3TRT9NphNP8sqnZhqblDNhqOlgo q3C+s205t/Cwu6fu91720IFvCf2vpV2PM94hzP5YeIYiVc5ojJFla16z5Otd4/pUg/0G DlO6OxpBppPDAZNfFIq2M1Li9ApGicTi2qe9whGgrPJYHG2Et7iT1AUuCeBl0LBXKxKw kvWw== X-Gm-Message-State: AGi0PuY+nfTOMfveweLUoKqLuXGt9SrDKQe/bMTIEKXqDA5PH4BrkpY4 0HU0C5RKQOK8srC9ZxbH8VqKVg== X-Google-Smtp-Source: APiQypJsinurJQlKKhBli7w6pCn0J6twQ6wYYsj5qr8ytdr2SAZP7IWJnQE1AJwhokOlwmwPMtM1cg== X-Received: by 2002:a17:907:b1a:: with SMTP id h26mr879545ejl.321.1586247331125; Tue, 07 Apr 2020 01:15:31 -0700 (PDT) Received: from [192.168.1.4] (212-5-158-179.ip.btc-net.bg. [212.5.158.179]) by smtp.googlemail.com with ESMTPSA id a24sm3175976ejy.38.2020.04.07.01.15.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Apr 2020 01:15:30 -0700 (PDT) From: Stanimir Varbanov Subject: Re: [PATCH] [PATCH] venus: core: remove CNOC voting while device suspend To: Mansur Alisha Shaik , linux-media@vger.kernel.org, stanimir.varbanov@linaro.org Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org References: <1581940891-2376-1-git-send-email-mansur@codeaurora.org> Message-ID: Date: Tue, 7 Apr 2020 11:15:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1581940891-2376-1-git-send-email-mansur@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mansur, The patch looks fine and correct but the description should be better. On 2/17/20 2:01 PM, Mansur Alisha Shaik wrote: > video driver is voting for CNOC during probe and not clear > while device suspend. Because of which XO shutdown is > happing(BCM42: VALID: 0x1 VOTE_X: 0x0000 VOTE_Y: 0x0004). > > So, clearing CNOC voting while device suspend. Maybe something like this ? The Venus driver is voting Configuration NoC during .probe but not clear voting in .suspend. As a consequence the whole device could leak energy while in suspend. Correct this by moving voting in .resume and unvoting in .suspend. > > Signed-off-by: Mansur Alisha Shaik > --- > drivers/media/platform/qcom/venus/core.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c > index e7995cb..153effe 100644 > --- a/drivers/media/platform/qcom/venus/core.c > +++ b/drivers/media/platform/qcom/venus/core.c > @@ -244,10 +244,6 @@ static int venus_probe(struct platform_device *pdev) > if (ret) > return ret; > > - ret = icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000)); > - if (ret) > - return ret; > - > ret = hfi_create(core, &venus_core_ops); > if (ret) > return ret; > @@ -353,6 +349,10 @@ static __maybe_unused int venus_runtime_suspend(struct device *dev) > if (ret) > return ret; > > + ret = icc_set_bw(core->cpucfg_path, 0, 0); > + if (ret) > + return ret; > + > if (pm_ops->core_power) > ret = pm_ops->core_power(dev, POWER_OFF); > > @@ -371,6 +371,10 @@ static __maybe_unused int venus_runtime_resume(struct device *dev) > return ret; > } > > + ret = icc_set_bw(core->cpucfg_path, 0, kbps_to_icc(1000)); > + if (ret) > + return ret; > + > return hfi_core_resume(core, false); > } > > -- regards, Stan -- regards, Stan