From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D036AC00140 for ; Tue, 2 Aug 2022 08:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235724AbiHBIqO (ORCPT ); Tue, 2 Aug 2022 04:46:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233069AbiHBIqM (ORCPT ); Tue, 2 Aug 2022 04:46:12 -0400 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE1FC18355 for ; Tue, 2 Aug 2022 01:46:10 -0700 (PDT) Received: by mail-lj1-x231.google.com with SMTP id z20so7766949ljq.3 for ; Tue, 02 Aug 2022 01:46:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=K7X8iIHy3LYj/4krwug3nx931AvXti0vH9iBS7pE2K4=; b=gKMlaGsVh25UzUYMjr4Vs6/HiaqzYMDs8EuW9FSc8JTkLiwtIaBKAxFLYvLHzemfv3 B/QzgEil+FtNljhSp9oMzcgbbnJn7osjyPu/4UWgeJoh/x6rrUitpXjrSL3ie13n9rGp u+7fk1bI+8s7iyQ7YODEmTTs80gLAw8YYnrhYcfwiYdm2MOb2mlzqfwKKLyYi9uD+tgv CCfK4OvfjAozqBZq82yurA4fnzOTHtXX7JcCrsN9TjKcuNJrZNG8FnWN+6KwWcAyv+Gd Bv5yoNZzwmUMv9/c6GucJm5fWWITzEHEJrTeO5HA2tNWtU/Ms9raJprzMkBypZjxXA1E CmbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=K7X8iIHy3LYj/4krwug3nx931AvXti0vH9iBS7pE2K4=; b=7y6wKRm5Hw8/tGmZtEWmD7HbpQ8mCO03fVLskPf+W1cSIPxfoPW+rHcW1XCBL4E0DB JLa9lGxUfsS+3Xkgs6heng/3LwjZjiEXfOGK0L0qkmkeiADfdV2GUN+JpzmgIXsjS7Sy MUkmGetoFocMZgRnUYHeB+kF0CetsqS0ou0+ptyZaqweQigS60l1fmDmFTz5LPIDPwT1 wCCAYpymLusjBQq+eprD/WxT3a8Qp1cznIY54I4ol8QO8y4Yatsn4ORcuWjsNZ3SMmeP J46pXLyiRDQh0cPtSs25uW9YT+KG2Hh1sTYhrjNYmZNQde+O6IMyH1jk3mrA3GxX17fv OCSw== X-Gm-Message-State: AJIora+QKdULIb3ErBKpiKqTD2w+beDm9yb9YO26PpcwHe1KkqaGc58W E7TXybuDs+L+FeAJtLk869+cO8kufvnrp8jx X-Google-Smtp-Source: AGRyM1upmtLknsx94k+qHnKPOHBBNE6qH3/UR5Vxo+HHCzeGIiCrY7Pv1IO/NKUma4lABAzfE7WyEA== X-Received: by 2002:a05:651c:1504:b0:25e:2443:9bfd with SMTP id e4-20020a05651c150400b0025e24439bfdmr5832466ljf.104.1659429969357; Tue, 02 Aug 2022 01:46:09 -0700 (PDT) Received: from [192.168.1.6] ([213.161.169.44]) by smtp.gmail.com with ESMTPSA id r4-20020ac25c04000000b0048a9ec2ce46sm2012205lfp.260.2022.08.02.01.46.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 01:46:08 -0700 (PDT) Message-ID: Date: Tue, 2 Aug 2022 10:46:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 4/4] dt-bindings: net: dsa: mediatek,mt7530: update json-schema Content-Language: en-US To: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , Frank Wunderlich , Luiz Angelo Daros de Luca , Sander Vanheule , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Daniel Golle , erkin.bozoglu@xeront.com, Sergio Paracuellos Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220730142627.29028-1-arinc.unal@arinc9.com> <20220730142627.29028-5-arinc.unal@arinc9.com> From: Krzysztof Kozlowski In-Reply-To: <20220730142627.29028-5-arinc.unal@arinc9.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/2022 16:26, Arınç ÜNAL wrote: > Update the json-schema for compatible devices. > > - Define acceptable phy-mode values for CPU port of each compatible device. > - Remove requiring the "reg" property since the referred dsa-port.yaml > already does that. > - Require mediatek,mcm for the described MT7621 SoCs as the compatible > string is only used for MT7530 which is a part of the multi-chip module. 3 separate patches. > > Signed-off-by: Arınç ÜNAL > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 220 +++++++++++++++--- > 1 file changed, 191 insertions(+), 29 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > index a88e650e910b..a37a14fba9f6 100644 > --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml > @@ -135,35 +135,6 @@ properties: > the ethsys. > maxItems: 1 > > -patternProperties: > - "^(ethernet-)?ports$": > - type: object Actually four patches... I don't find this change explained in commit msg. What is more, it looks incorrect. All properties and patternProperties should be explained in top-level part. Defining such properties (with big piece of YAML) in each if:then: is no readable. > - > - patternProperties: Best regards, Krzysztof