* Re: [PATCH] ipmi: bt-bcm: Use platform_get_irq_optional()
@ 2020-04-03 19:02 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-04-03 19:02 UTC (permalink / raw)
To: Tang Bin, Arnd Bergmann, Corey Minyard, Greg Kroah-Hartman,
openipmi-developer
Cc: linux-kernel, kernel-janitors
> In this function's reference function 'bt_bmc_probe()',
I have got understanding difficulties for this information.
Would you like to refer to the function “bt_bmc_config_irq”?
> there are judgments of print message about 'bt_bmc->irq',
Would an other wording be nicer?
> so use platform_get_irq_optional() instead of platform_get_irq()
> to avoid redundant dev_err() message.
Will a separate sentence be helpful?
How do you think about another bit of fine-tuning for the commit message?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-04-03 19:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-03 19:02 [PATCH] ipmi: bt-bcm: Use platform_get_irq_optional() Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).