From: Pkshih <pkshih@realtek.com>
To: "cgel.zte@gmail.com" <cgel.zte@gmail.com>
Cc: "kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lv Ruyi <lv.ruyi@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>
Subject: RE: [PATCH V2] rtw89: fix error function parameter
Date: Thu, 21 Oct 2021 05:22:14 +0000 [thread overview]
Message-ID: <e5dfff36092b4caaaa85610baf64f295@realtek.com> (raw)
In-Reply-To: <20211021042035.1042463-1-lv.ruyi@zte.com.cn>
> -----Original Message-----
> From: cgel.zte@gmail.com <cgel.zte@gmail.com>
> Sent: Thursday, October 21, 2021 12:21 PM
> To: Pkshih <pkshih@realtek.com>
> Cc: kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org; linux-wireless@vger.kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Lv Ruyi <lv.ruyi@zte.com.cn>; Zeal Robot
> <zealci@zte.com.cn>
> Subject: [PATCH V2] rtw89: fix error function parameter
>
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING possible condition with no effect (if == else)
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
I think you can say something about the changes of v2 followed by '---', like
---
v2: fix tabs are converted to spaces
> ---
> drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> index b1b87f0aadbb..5c6ffca3a324 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> @@ -757,7 +757,7 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
> else
^^^^^^
I have confirmed this is a tab.
> rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
> B_P1_MODE_SEL,
> - 1, phy_idx);
> + 0, phy_idx);
> /* SCO compensate FC setting */
> sco_comp = rtw8852a_sco_mapping(central_ch);
> rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
> --
> 2.25.1
next prev parent reply other threads:[~2021-10-21 5:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 3:53 [PATCH] rtw89: fix error function parameter cgel.zte
2021-10-19 5:21 ` Pkshih
2021-10-20 8:50 ` Kalle Valo
2021-10-20 9:46 ` Pkshih
2021-10-20 10:03 ` Kalle Valo
2021-10-21 1:34 ` Pkshih
2021-10-21 3:10 ` CGEL
2021-10-21 4:20 ` [PATCH V2] " cgel.zte
2021-10-21 5:22 ` Pkshih [this message]
2021-10-27 7:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5dfff36092b4caaaa85610baf64f295@realtek.com \
--to=pkshih@realtek.com \
--cc=cgel.zte@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=netdev@vger.kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).