From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752483AbdLEVzU (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Dec 2017 16:55:20 -0500
Received: from bhuna.collabora.co.uk ([46.235.227.227]:58024 "EHLO
        bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752387AbdLEVzT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Dec 2017 16:55:19 -0500
From: Thierry Escande <thierry.escande@collabora.com>
Subject: Re: [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for
 Google Glimmer
To: Gwendal Grignou <gwendal@chromium.org>
Cc: Benson Leung <bleung@chromium.org>, Lee Jones <lee.jones@linaro.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>
References: <1512135743-16529-1-git-send-email-thierry.escande@collabora.com>
 <1512135743-16529-3-git-send-email-thierry.escande@collabora.com>
 <CAMHSBOU_Xkd=cOCU_KFR_ytY8azjOzLWUNOgeDnE-dGTEW=4Jg@mail.gmail.com>
Message-ID: <e61244cb-d82f-dd85-ddff-9fa47dbbf0ab@collabora.com>
Date: Tue, 5 Dec 2017 22:55:14 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CAMHSBOU_Xkd=cOCU_KFR_ytY8azjOzLWUNOgeDnE-dGTEW=4Jg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Gwendal,

On 01/12/2017 20:54, Gwendal Grignou wrote:
> This is not required.
> Looking with dmidecode, Glimmer reports:
> ...
> BIOS Information
>          Vendor: coreboot
>          Version: Google_Glimmer.5216.198.19
> ...
> 
> Therefore, the first entry of cros_ec_lpc_dmi_table will match.

These DMI vendor/version strings are not exposed when booting in legacy 
mode using SeaBIOS on the Yoga 11e. Instead it matches with the pair 
GOOGLE/Glimmer. So this patch is needed for booting a vanilla kernel in 
legacy mode.

Regards,
  Thierry

> 
> Gwendal.
> 
> On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande
> <thierry.escande@collabora.com> wrote:
>> This patch adds device information to the DMI table of the cros_ec_lpc
>> driver for Google Glimmer devices. Since Google BIOS does not enumerate
>> devices in the LPC bus, the cros_ec_lpc driver checks for system
>> compatibility and registers the cros_ec device itself.
>>
>> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
>> ---
>>   drivers/platform/chrome/cros_ec_lpc.c | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
>> index 0b26a09..4a2fc55 100644
>> --- a/drivers/platform/chrome/cros_ec_lpc.c
>> +++ b/drivers/platform/chrome/cros_ec_lpc.c
>> @@ -365,6 +365,13 @@ static const struct dmi_system_id cros_ec_lpc_dmi_table[] __initconst = {
>>                          DMI_MATCH(DMI_PRODUCT_NAME, "Peppy"),
>>                  },
>>          },
>> +       {
>> +               /* x86-glimmer, the Lenovo Thinkpad Yoga 11e. */
>> +               .matches = {
>> +                       DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
>> +                       DMI_MATCH(DMI_PRODUCT_NAME, "Glimmer"),
>> +               },
>> +       },
>>          { /* sentinel */ }
>>   };
>>   MODULE_DEVICE_TABLE(dmi, cros_ec_lpc_dmi_table);
>> --
>> 2.7.4
>>