From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 873CDC2D0EA for ; Wed, 8 Apr 2020 13:17:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 439FA2072A for ; Wed, 8 Apr 2020 13:17:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=yandex.ru header.i=@yandex.ru header.b="klGqDbBm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729054AbgDHNRN (ORCPT ); Wed, 8 Apr 2020 09:17:13 -0400 Received: from forward101j.mail.yandex.net ([5.45.198.241]:41158 "EHLO forward101j.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728484AbgDHNRN (ORCPT ); Wed, 8 Apr 2020 09:17:13 -0400 Received: from forward101q.mail.yandex.net (forward101q.mail.yandex.net [IPv6:2a02:6b8:c0e:4b:0:640:4012:bb98]) by forward101j.mail.yandex.net (Yandex) with ESMTP id 2B0DD1BE259D; Wed, 8 Apr 2020 16:17:10 +0300 (MSK) Received: from mxback7q.mail.yandex.net (mxback7q.mail.yandex.net [IPv6:2a02:6b8:c0e:41:0:640:cbbf:d618]) by forward101q.mail.yandex.net (Yandex) with ESMTP id 28170CF40007; Wed, 8 Apr 2020 16:17:10 +0300 (MSK) Received: from vla4-2e76570dd7f5.qloud-c.yandex.net (vla4-2e76570dd7f5.qloud-c.yandex.net [2a02:6b8:c17:c8b:0:640:2e76:570d]) by mxback7q.mail.yandex.net (mxback/Yandex) with ESMTP id yyyfb7s1NS-H9x026fN; Wed, 08 Apr 2020 16:17:10 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1586351830; bh=QICxSrOBFKEqCY/3Lc54+2QUvUNhDgqEpKodDF5z+hw=; h=In-Reply-To:Cc:To:From:Subject:References:Date:Message-ID; b=klGqDbBm6qFEA4IeFtQ84Wdke69SIVV36iC8bADRA9wueDhM1yAC6GowbEsiw/Ccb eD7P8wYUAbVkt8SD0Ry6rrhgZhsn9a7ophx/VaVEnPY2fzFDovdajeslBa6DIjrC14 /0H3hJj0cVH66M5f+algGkygYfGXK+76FPieq+Nk= Authentication-Results: mxback7q.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by vla4-2e76570dd7f5.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id omL8cJmw5C-H8WaEfNU; Wed, 08 Apr 2020 16:17:08 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Message-ID: Subject: Re: [PATCH] virtio: virtio_console: add missing MODULE_DEVICE_TABLE() for rproc serial From: Alexander Lobakin To: Amit Shah Cc: Arnd Bergmann , Greg Kroah-Hartman , Sjur Brandeland , Rusty Russell , virtualization@lists.linux-foundation.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 08 Apr 2020 16:17:07 +0300 In-Reply-To: References: <20200310110538.19254-1-alobakin@dlink.ru> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-03-11 at 15:53 +0100, Amit Shah wrote: > On Tue, 2020-03-10 at 14:05 +0300, Alexander Lobakin wrote: > > rproc_serial_id_table lacks an exposure to module devicetable, so > > when remoteproc firmware requests VIRTIO_ID_RPROC_SERIAL, no uevent > > is generated and no module autoloading occurs. > > Add missing MODULE_DEVICE_TABLE() annotation and move the existing > > one for VIRTIO_ID_CONSOLE right to the table itself. > > > > Fixes: 1b6370463e88 ("virtio_console: Add support for remoteproc > > serial") > > Cc: # v3.8+ > > Signed-off-by: Alexander Lobakin > > Reviewed-by: Amit Shah Thank you! Well, who will take this into his tree? > Thanks, > > > --- > > drivers/char/virtio_console.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/char/virtio_console.c > > b/drivers/char/virtio_console.c > > index 4df9b40d6342..7e1bc0f580a2 100644 > > --- a/drivers/char/virtio_console.c > > +++ b/drivers/char/virtio_console.c > > @@ -2116,6 +2116,7 @@ static struct virtio_device_id id_table[] = { > > { VIRTIO_ID_CONSOLE, VIRTIO_DEV_ANY_ID }, > > { 0 }, > > }; > > +MODULE_DEVICE_TABLE(virtio, id_table); > > > > static unsigned int features[] = { > > VIRTIO_CONSOLE_F_SIZE, > > @@ -2128,6 +2129,7 @@ static struct virtio_device_id > > rproc_serial_id_table[] = { > > #endif > > { 0 }, > > }; > > +MODULE_DEVICE_TABLE(virtio, rproc_serial_id_table); > > > > static unsigned int rproc_serial_features[] = { > > }; > > @@ -2280,6 +2282,5 @@ static void __exit fini(void) > > module_init(init); > > module_exit(fini); > > > > -MODULE_DEVICE_TABLE(virtio, id_table); > > MODULE_DESCRIPTION("Virtio console driver"); > > MODULE_LICENSE("GPL");