From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7CCCC4363A for ; Thu, 8 Oct 2020 13:45:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7375E2083B for ; Thu, 8 Oct 2020 13:45:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730386AbgJHNpg (ORCPT ); Thu, 8 Oct 2020 09:45:36 -0400 Received: from foss.arm.com ([217.140.110.172]:58430 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728969AbgJHNpd (ORCPT ); Thu, 8 Oct 2020 09:45:33 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B3D541529; Thu, 8 Oct 2020 06:45:32 -0700 (PDT) Received: from [192.168.2.22] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B61CF3F70D; Thu, 8 Oct 2020 06:45:30 -0700 (PDT) From: =?UTF-8?Q?Andr=c3=a9_Przywara?= Subject: Re: [PATCH v2 01/14] perf arm-spe: Include bitops.h for BIT() macro To: Leo Yan , Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Wei Li , James Clark , Dave Martin , linux-kernel@vger.kernel.org, Al Grant References: <20200929133917.9224-1-leo.yan@linaro.org> <20200929133917.9224-2-leo.yan@linaro.org> Organization: ARM Ltd. Message-ID: Date: Thu, 8 Oct 2020 14:44:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200929133917.9224-2-leo.yan@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/2020 14:39, Leo Yan wrote: > Include header linux/bitops.h, directly use its BIT() macro and remove > the self defined macros. > > Signed-off-by: Leo Yan Reviewed-by: Andre Przywara Thanks, Andre > --- > tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 5 +---- > tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 3 +-- > 2 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c > index 93e063f22be5..cc18a1e8c212 100644 > --- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c > +++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -21,10 +22,6 @@ > > #include "arm-spe-decoder.h" > > -#ifndef BIT > -#define BIT(n) (1UL << (n)) > -#endif > - > static u64 arm_spe_calc_ip(int index, u64 payload) > { > u8 *addr = (u8 *)&payload; > diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c > index b94001b756c7..46ddb53a6457 100644 > --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c > +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c > @@ -8,11 +8,10 @@ > #include > #include > #include > +#include > > #include "arm-spe-pkt-decoder.h" > > -#define BIT(n) (1ULL << (n)) > - > #define NS_FLAG BIT(63) > #define EL_FLAG (BIT(62) | BIT(61)) > >