* [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration
@ 2019-03-17 1:59 Emanuel Bennici
2019-03-17 9:55 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Emanuel Bennici @ 2019-03-17 1:59 UTC (permalink / raw)
To: Eric Anholt, Stefan Wahren, Greg Kroah-Hartman; +Cc: linux-kernel, devel
Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h b/drivers/staging/vc04_services/interface/vchi/vchi.h
index 7b13cb04c119..43eaf7703777 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi.h
@@ -55,6 +55,7 @@ struct vchi_version {
uint32_t version;
uint32_t version_min;
};
+
#define VCHI_VERSION(v_) { v_, v_ }
#define VCHI_VERSION_EX(v_, m_) { v_, m_ }
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration
2019-03-17 1:59 [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration Emanuel Bennici
@ 2019-03-17 9:55 ` Greg Kroah-Hartman
2019-03-17 12:14 ` Emanuel Bennici
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-03-17 9:55 UTC (permalink / raw)
To: Emanuel Bennici; +Cc: Eric Anholt, Stefan Wahren, devel, linux-kernel
On Sun, Mar 17, 2019 at 02:59:32AM +0100, Emanuel Bennici wrote:
> Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
> ---
> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
> 1 file changed, 1 insertion(+)
I can not take patches without any changelog information, sorry.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration
2019-03-17 9:55 ` Greg Kroah-Hartman
@ 2019-03-17 12:14 ` Emanuel Bennici
2019-03-17 12:38 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Emanuel Bennici @ 2019-03-17 12:14 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Eric Anholt, Stefan Wahren, devel, linux-kernel
Am 17.03.19 um 10:55 schrieb Greg Kroah-Hartman:
> On Sun, Mar 17, 2019 at 02:59:32AM +0100, Emanuel Bennici wrote:
>> Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
>> ---
>> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
>> 1 file changed, 1 insertion(+)
> I can not take patches without any changelog information, sorry.
Add blank Line after declaration of struct vchi_version to fix checkpatch.pl
Check `CHECK: Please use a blank line after function/struct/union/enum
declarations`.
Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
---
drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/vc04_services/interface/vchi/vchi.h
b/drivers/staging/vc04_services/interface/vchi/vchi.h
index 7b13cb04c119..43eaf7703777 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi.h
@@ -55,6 +55,7 @@ struct vchi_version {
uint32_t version;
uint32_t version_min;
};
+
#define VCHI_VERSION(v_) { v_, v_ }
#define VCHI_VERSION_EX(v_, m_) { v_, m_ }
--
2.19.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration
2019-03-17 12:14 ` Emanuel Bennici
@ 2019-03-17 12:38 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2019-03-17 12:38 UTC (permalink / raw)
To: Emanuel Bennici; +Cc: Stefan Wahren, Eric Anholt, devel, linux-kernel
On Sun, Mar 17, 2019 at 01:14:26PM +0100, Emanuel Bennici wrote:
>
> Am 17.03.19 um 10:55 schrieb Greg Kroah-Hartman:
> > On Sun, Mar 17, 2019 at 02:59:32AM +0100, Emanuel Bennici wrote:
> >> Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
> >> ---
> >> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
> >> 1 file changed, 1 insertion(+)
> > I can not take patches without any changelog information, sorry.
>
> Add blank Line after declaration of struct vchi_version to fix checkpatch.pl
> Check `CHECK: Please use a blank line after function/struct/union/enum
> declarations`.
>
> Signed-off-by: Emanuel Bennici <benniciemanuel78@gmail.com>
> ---
> drivers/staging/vc04_services/interface/vchi/vchi.h | 1 +
> 1 file changed, 1 insertion(+)
>
<snip>
Sorry, I can't take a patch that I have to hand-edit either.
Please fix up and resend the series correctly, with a proper version
information about what changed from the previous patch series as the
kernel process documentation explains.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-17 12:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-17 1:59 [PATCH 2/2] staging: vc04_services: Add blank line after struct declaration Emanuel Bennici
2019-03-17 9:55 ` Greg Kroah-Hartman
2019-03-17 12:14 ` Emanuel Bennici
2019-03-17 12:38 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).