From: Mikita Lipski <mlipski@amd.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Dave Airlie <airlied@gmail.com>,
Mikita Lipski <mikita.lipski@amd.com>,
Sun peng Li <Sunpeng.Li@amd.com>,
Qingqing Zhuo <qingqing.zhuo@amd.com>,
Alex Deucher <alexander.deucher@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] drm for 5.13-rc1
Date: Wed, 28 Apr 2021 20:14:41 -0400 [thread overview]
Message-ID: <e6532806-ba36-d5d0-6d74-488182787a6c@amd.com> (raw)
In-Reply-To: <CAHk-=wh3x4Q4pCkYe7__OAnvOyPqdZLN5ha0z4U035FwT5G57w@mail.gmail.com>
Hi Linus,
The patch to fix the warning is here
(https://www.spinics.net/lists/amd-gfx/msg61614.html)
I guess it just didn't propagate all the way to the release.
Can it still be pulled into 5.13-rc1 release?
From: Mikita Lipski <mikita.lipski@xxxxxxx>
[why]
Previous statement would always evaluate to true
making it meaningless
[how]
Just check if a connector is MST by checking if its port exists.
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: Mikita Lipski <mikita.lipski@xxxxxxx>
Reviewed-by: Nicholas Kazlauskas <Nicholas.Kazlauskas@xxxxxxx>
Acked-by: Wayne Lin <waynelin@xxxxxxx>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
index 656bc8f00a42..8bf0b566612b 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c
@@ -3030,7 +3030,7 @@ static int trigger_hpd_mst_set(void *data, u64 val)
if (!aconnector->dc_link)
continue;
- if (!(aconnector->port && &aconnector->mst_port->mst_mgr))
+ if (!aconnector->mst_port)
continue;
link = aconnector->dc_link;
--
2.17.1
Thanks,
Mikita
On 2021-04-28 6:21 p.m., Linus Torvalds wrote:
> On Tue, Apr 27, 2021 at 8:32 PM Dave Airlie <airlied@gmail.com> wrote:
>>
>> This is the main drm pull request for 5.13. The usual lots of work all
>> over the place. [...]
>>
>> Mikita Lipski:
>> drm/amd/display: Add MST capability to trigger_hotplug interface
>
> Hmm. I've already merged this, but my clang build shows that this looks buggy:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_dm/amdgpu_dm_debugfs.c:3015:53:
> warning: address of 'aconnector->mst_port->mst_mgr' will always
> evaluate to 'true' [-Wpointer-bool-conversion]
> if (!(aconnector->port &&
> &aconnector->mst_port->mst_mgr))
> ~~ ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
>
> and yeah, checking for the address of a member of a structure benign
> NULL doesn't really work.
>
> I'm assuming the '&' is just a left-over cut-and-paste error or something.
>
> Please fix after reviewing (I'm not going to blindly just remove the
> '&' just to silence the warning, since I don't know the code).
>
> Linus
>
next prev parent reply other threads:[~2021-04-29 0:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 3:31 [git pull] drm for 5.13-rc1 Dave Airlie
2021-04-28 17:07 ` Linus Torvalds
2021-04-28 18:14 ` Daniel Vetter
2021-04-28 18:16 ` Linus Torvalds
2021-04-28 17:33 ` pr-tracker-bot
2021-04-28 22:21 ` Linus Torvalds
2021-04-29 0:14 ` Mikita Lipski [this message]
2021-04-29 2:09 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6532806-ba36-d5d0-6d74-488182787a6c@amd.com \
--to=mlipski@amd.com \
--cc=Sunpeng.Li@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikita.lipski@amd.com \
--cc=qingqing.zhuo@amd.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).