linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
	Po-Hsu Lin <po-hsu.lin@canonical.com>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	mingo@redhat.com, mhiramat@kernel.org, joel@joelfernandes.org,
	Shuah Khan <skhan@linuxfoundation.org>, shuah <shuah@kernel.org>
Subject: Re: [PATCH] selftests/ftrace: mark irqsoff_tracer.tc test as unresolved if the test module does not exist
Date: Tue, 5 May 2020 08:22:57 -0600	[thread overview]
Message-ID: <e6726e67-243e-876d-9e37-47b40d4bca5c@kernel.org> (raw)
In-Reply-To: <20200505090912.7114f420@gandalf.local.home>

On 5/5/20 7:09 AM, Steven Rostedt wrote:
> 
> You keep forgetting to Cc Shuah's other email.
> 
> On Tue,  5 May 2020 18:14:45 +0800
> Po-Hsu Lin <po-hsu.lin@canonical.com> wrote:
> 
>> The UNRESOLVED state is much more apporiate than the UNSUPPORTED state
>> for the absence of the test module, as it matches "test was set up
>> incorrectly" situation in the README file.
>>
>> A possible scenario is that the function was enabled (supported by the
>> kernel) but the module was not installed properly, in this case we
>> cannot call this as UNSUPPORTED.
>>
>> This change also make it consistent with other module-related tests
>> in ftrace.
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> Shuah,
> 
> Can you take this after Masami gives his ack (if he does that is).
> 

Yes. I will wait for Masamis's Ack. Will do.

thanks,
-- Shuah

  reply	other threads:[~2020-05-05 14:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 10:14 [PATCH] selftests/ftrace: mark irqsoff_tracer.tc test as unresolved if the test module does not exist Po-Hsu Lin
2020-05-05 13:09 ` Steven Rostedt
2020-05-05 14:22   ` shuah [this message]
2020-05-06  1:46   ` Po-Hsu Lin
2020-05-06 15:43     ` Steven Rostedt
2020-05-06 15:46       ` Shuah Khan
2020-05-07  8:50 ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6726e67-243e-876d-9e37-47b40d4bca5c@kernel.org \
    --to=shuah@kernel.org \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=po-hsu.lin@canonical.com \
    --cc=rostedt@goodmis.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).