From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5DA1C43441 for ; Tue, 13 Nov 2018 10:33:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BB9A223C8 for ; Tue, 13 Nov 2018 10:33:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="EKrodrTo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BB9A223C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732286AbeKMUah (ORCPT ); Tue, 13 Nov 2018 15:30:37 -0500 Received: from mail-yw1-f67.google.com ([209.85.161.67]:33007 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731910AbeKMUag (ORCPT ); Tue, 13 Nov 2018 15:30:36 -0500 Received: by mail-yw1-f67.google.com with SMTP id z72-v6so5615744ywa.0 for ; Tue, 13 Nov 2018 02:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=NyYpLHlfZ8OpG/z1ZpKYhyX6Kd3r9biiDvUXTGgfQz4=; b=EKrodrTo/oOmwOvAH9m8eCxJTRiCfRZO6qkzWdwzKl696at/TN2cDunKUq0e26r43E 2pHfYgy3OjneKoIa3enJLKHC0qiT0PTTBRWtaECItJXj8J07Z4YKAK1h1LBAsMHbTsGH NTE365ZKmbEjZx761y64OMv9dqDFNLcGi0Xlc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=NyYpLHlfZ8OpG/z1ZpKYhyX6Kd3r9biiDvUXTGgfQz4=; b=HEZdJo2jBl9nXIArZz+1v31AP/weRkN9fE4HFAmRy5tel3iYojqMPDBjOxJ3eHFyg+ i7sFyvno+sMu1mS8H84V+ucSM50Grghna2r6Fz9OO1iQYsGCWJnKLyH9w17YY6u2KYrQ nc4O215LCbYS+/nEhfhA4O8mI3LB1WwoKVcp8gLPZu+BdqCpaxJHztdZTspQHg8MDfkB cMsmmuhgnqtTgrV1vKb4UEy7yEIVdrieqSV0vfEwtXXatnxPHhz0O+UbKIYCSwOpPVUU br96WRR7ecrCNRLpnXmilo6/8MYkcy8UO79z89QEqsJKCJH8YfUL8hRmT9ydIeeuM55P m1WA== X-Gm-Message-State: AGRZ1gI+BTD0lpun+LmshwlFZru9H3pp9O2JBq3BCMe2Ma74t3yNIz4m c3AsVkEiP0sOMe2NiC+q6xsQ/A== X-Google-Smtp-Source: AJdET5cVUNcwf9Z/ACVkg4lgGm59tmZJG11Z5CXkCCf7jc9RdurWHkC0Swda/Qjhy33csu59Z3/ugg== X-Received: by 2002:a81:a60d:: with SMTP id d13-v6mr4249226ywh.373.1542105187097; Tue, 13 Nov 2018 02:33:07 -0800 (PST) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id f1-v6sm6037879ywb.89.2018.11.13.02.33.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Nov 2018 02:33:06 -0800 (PST) Subject: Re: [REGRESSION] brcmfmac: NULL pointer deference starting next-20181107 To: Jon Hunter , Hans de Goede , Kalle Valo , linux-tegra , linux-wireless@vger.kernel.org, Linux Kernel Mailing List , Ard Biesheuvel References: <9f72ac4f-a83a-7af7-3c26-b1ced6d98653@broadcom.com> From: Arend van Spriel Message-ID: Date: Tue, 13 Nov 2018 11:33:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <9f72ac4f-a83a-7af7-3c26-b1ced6d98653@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/2018 11:24 AM, Arend van Spriel wrote: > + Ard as this involves EFI. > > On 11/12/2018 2:24 PM, Jon Hunter wrote: >> Hi Hans, Kalle, >> >> Starting with next-20181107 I am seeing the following NULL pointer >> deference on Tegra (note the firmware is missing on this board) ... >> >> [ 14.072883] brcmfmac: brcmf_fw_alloc_request: using >> brcm/brcmfmac4329-sdio for chip BCM4329/3 >> >> [ 14.130287] brcmfmac mmc1:0001:1: Direct firmware load for >> brcm/brcmfmac4329-sdio.nvidia,cardhu-a04.txt failed with error -2 >> >> [ 14.156283] brcmfmac mmc1:0001:1: Direct firmware load for >> brcm/brcmfmac4329-sdio.txt failed with error -2 >> >> [ 14.177769] Unable to handle kernel NULL pointer dereference at >> virtual address 00000008 >> >> [ 14.197303] pgd = 60bfa5f1 >> >> [ 14.211842] [00000008] *pgd=00000000 >> >> [ 14.227373] Internal error: Oops: 5 [#1] SMP ARM >> >> [ 14.244244] Modules linked in: brcmfmac sha256_generic sha256_arm >> snd cfg80211 brcmutil soundcore snd_soc_tegra30_ahub tegra_wdt >> >> [ 14.269109] CPU: 1 PID: 114 Comm: kworker/1:2 Not tainted >> 4.20.0-rc1-next-20181107-gd881de3 #1 >> >> [ 14.269114] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) >> >> [ 14.269154] Workqueue: events request_firmware_work_func >> >> [ 14.269177] PC is at efivar_entry_size+0x28/0x90 >> >> [ 14.269362] LR is at brcmf_fw_complete_request+0x3f8/0x8d4 [brcmfmac] >> >> [ 14.269369] pc : [] lr : [] psr: a00d0113 >> >> [ 14.269374] sp : ede7fe28 ip : ee983410 fp : c1787f30 >> >> [ 14.269378] r10: 00000000 r9 : 00000000 r8 : bf2b2258 >> >> [ 14.269384] r7 : ee983000 r6 : c1604c48 r5 : ede7fe88 r4 : edf337c0 >> >> [ 14.269389] r3 : 00000000 r2 : 00000000 r1 : ede7fe88 r0 : c17712c8 >> > > Hi Jon, > > I tried building drivers/firmware/efi/vars.c using tegra_defconfig. Had > to enable CONFIG_EFI. So the null pointer access is a 0x00000008 so I > looked at the disassembly below: > > int efivar_entry_size(struct efivar_entry *entry, unsigned long *size) > { > 310: e1a05001 mov r5, r1 > const struct efivar_operations *ops = __efivars->ops; > ==> 314: e5936008 ldr r6, [r3, #8] > > So I think __efivars is NULL on your platform. It is private to the > source file. Not sure how the driver should deal with this. Maybe use > efi_enabled() but not sure what feature to use. My best bet would be > EFI_RUNTIME_SERVICES. Another API function to check could be efivars_kobject(), which returns NULL if __efivars is NULL. Regards, Arend