[PATCH] genirq: show irq name in non-oneshot error message

[PATCH] genirq: show irq name in non-oneshot error message

[Luca Ceresoli]

Requesting a threaded IRQ with handler=NULL and !ONESHOT fails, but the
error message does not include the IRQ line name, which makes it harder to
find the offending driver.

Print the IRQ line name to clarify where the error comes from. Use the same
format as other pr_err() above in the same function.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
---
 kernel/irq/manage.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 1753486b440c..b6c53ab053d2 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1500,8 +1500,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
 		 * has. The type flags are unreliable as the
 		 * underlying chip implementation can override them.
 		 */
-		pr_err("Threaded irq requested with handler=NULL and !ONESHOT for irq %d\n",
-		       irq);
+		pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n",
+		       new->name, irq);
 		ret = -EINVAL;
 		goto out_unlock;
 	}
-- 
2.23.0

Re: [PATCH] genirq: show irq name in non-oneshot error message

[Luca Ceresoli]

Hi,

On 05/11/19 15:08, Luca Ceresoli wrote:
> Requesting a threaded IRQ with handler=NULL and !ONESHOT fails, but the
> error message does not include the IRQ line name, which makes it harder to
> find the offending driver.
> 
> Print the IRQ line name to clarify where the error comes from. Use the same
> format as other pr_err() above in the same function.
> 
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
>  kernel/irq/manage.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index 1753486b440c..b6c53ab053d2 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -1500,8 +1500,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
>  		 * has. The type flags are unreliable as the
>  		 * underlying chip implementation can override them.
>  		 */
> -		pr_err("Threaded irq requested with handler=NULL and !ONESHOT for irq %d\n",
> -		       irq);
> +		pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n",
> +		       new->name, irq);

Gently pinging about this trivial patch.

Should I send it elsewhere than where get_maintainer.pl suggests?

Thanks,
-- 
Luca

[tip: irq/core] genirq: Show irq name in non-oneshot error message

[tip-bot2 for Luca Ceresoli]

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     025af39b87dc4dc78de4e861ca8b88a1d5ba89f6
Gitweb:        https://git.kernel.org/tip/025af39b87dc4dc78de4e861ca8b88a1d5ba89f6
Author:        Luca Ceresoli <luca@lucaceresoli.net>
AuthorDate:    Tue, 05 Nov 2019 15:08:54 +01:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 09 Jan 2020 15:42:54 +01:00

genirq: Show irq name in non-oneshot error message

Requesting a threaded IRQ with handler=NULL and !ONESHOT fails, but the
error message does not include the IRQ line name, which makes it harder to
find the offending driver.

Print the IRQ line name to clarify where the error comes from. Use the same
format as the other pr_err() above in the same function.

Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20191105140854.27893-1-luca@lucaceresoli.net

---
 kernel/irq/manage.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 1753486..b6c53ab 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -1500,8 +1500,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new)
 		 * has. The type flags are unreliable as the
 		 * underlying chip implementation can override them.
 		 */
-		pr_err("Threaded irq requested with handler=NULL and !ONESHOT for irq %d\n",
-		       irq);
+		pr_err("Threaded irq requested with handler=NULL and !ONESHOT for %s (irq %d)\n",
+		       new->name, irq);
 		ret = -EINVAL;
 		goto out_unlock;
 	}