From: Casey Schaufler <casey@schaufler-ca.com>
To: Mirsad Goran Todorovac <mirsad.goran.todorovac@alu.hr>,
linux-kernel@vger.kernel.org
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"Paul Moore" <paul@paul-moore.com>,
"Christian Göttsche" <cgzones@googlemail.com>,
"Mickaël Salaün" <mic@digikod.net>,
"Frederick Lawler" <fred@cloudflare.com>,
casey@schaufler-ca.com
Subject: Re: [PATCH v1 0/2] Add destructor hook to LSM modules
Date: Fri, 10 Mar 2023 12:49:57 -0800 [thread overview]
Message-ID: <e6a975ce-3880-1429-f013-40604e361c8f@schaufler-ca.com> (raw)
In-Reply-To: <20230310192614.GA528@domac.alu.hr>
On 3/10/2023 11:26 AM, Mirsad Goran Todorovac wrote:
> LSM security/integrity/iint.c had the case of kmem_cache_create() w/o a proper
> kmem_cache_destroy() destructor.
LSMs should be using the security blobs associated with system objects
rather than doing their own memory management.
>
> Introducing the release() hook would enable LSMs to release allocated resources
> on exit, and in proper order, rather than dying all together with kernel shutdown
> in an undefined order.
>
> Thanks,
> Mirsad
>
> ---
> include/linux/lsm_hooks.h | 1 +
> security/integrity/iint.c | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> --
> Mirsad Goran Todorovac
> Sistem inženjer
> Grafički fakultet | Akademija likovnih umjetnosti
> Sveučilište u Zagrebu
>
> System engineer
> Faculty of Graphic Arts | Academy of Fine Arts
> University of Zagreb, Republic of Croatia
> The European Union
next prev parent reply other threads:[~2023-03-10 20:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 19:26 [PATCH v1 0/2] Add destructor hook to LSM modules Mirsad Goran Todorovac
2023-03-10 19:46 ` Andy Shevchenko
2023-03-10 20:49 ` Casey Schaufler [this message]
2023-03-10 22:33 ` Paul Moore
2023-03-10 22:53 ` Mirsad Goran Todorovac
2023-03-11 14:59 ` Paul Moore
2023-03-11 15:56 ` Mirsad Goran Todorovac
2023-03-13 9:32 ` Andy Shevchenko
2023-03-13 20:27 ` Paul Moore
2023-03-14 11:05 ` Andy Shevchenko
2023-03-14 12:04 ` Greg Kroah-Hartman
2023-03-14 16:32 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6a975ce-3880-1429-f013-40604e361c8f@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cgzones@googlemail.com \
--cc=fred@cloudflare.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=mic@digikod.net \
--cc=mirsad.goran.todorovac@alu.hr \
--cc=paul@paul-moore.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).