From: David Hildenbrand <david@redhat.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>, Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Dave Young <dyoung@redhat.com>,
Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Oscar Salvador <osalvador@suse.de>,
Mike Rapoport <rppt@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
x86@kernel.org, xen-devel@lists.xenproject.org,
virtualization@lists.linux-foundation.org,
kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v1 2/8] x86/xen: simplify xen_oldmem_pfn_is_ram()
Date: Wed, 29 Sep 2021 17:07:10 +0200 [thread overview]
Message-ID: <e6ace8c8-8a2d-9bf7-e65b-91d0037c4d08@redhat.com> (raw)
In-Reply-To: <3b935aa0-6d85-0bcd-100e-15098add3c4c@oracle.com>
On 29.09.21 16:22, Boris Ostrovsky wrote:
>
> On 9/29/21 5:03 AM, David Hildenbrand wrote:
>> On 29.09.21 10:45, David Hildenbrand wrote:
>>>>
>>> Can we go one step further and do
>>>
>>>
>>> @@ -20,24 +20,11 @@ static int xen_oldmem_pfn_is_ram(unsigned long pfn)
>>> struct xen_hvm_get_mem_type a = {
>>> .domid = DOMID_SELF,
>>> .pfn = pfn,
>>> + .mem_type = HVMMEM_ram_rw,
>>> };
>>> - int ram;
>>> - if (HYPERVISOR_hvm_op(HVMOP_get_mem_type, &a))
>>> - return -ENXIO;
>>> -
>>> - switch (a.mem_type) {
>>> - case HVMMEM_mmio_dm:
>>> - ram = 0;
>>> - break;
>>> - case HVMMEM_ram_rw:
>>> - case HVMMEM_ram_ro:
>>> - default:
>>> - ram = 1;
>>> - break;
>>> - }
>>> -
>>> - return ram;
>>> + HYPERVISOR_hvm_op(HVMOP_get_mem_type, &a);
>>> + return a.mem_type != HVMMEM_mmio_dm;
>
>
> I was actually thinking of asking you to add another patch with pr_warn_once() here (and print error code as well). This call failing is indication of something going quite wrong and it would be good to know about this.
Will include a patch in v2, thanks!
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-09-29 15:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 18:22 [PATCH v1 0/8] proc/vmcore: sanitize access to virtio-mem memory David Hildenbrand
2021-09-28 18:22 ` [PATCH v1 1/8] x86/xen: update xen_oldmem_pfn_is_ram() documentation David Hildenbrand
2021-09-29 1:16 ` Boris Ostrovsky
2021-09-28 18:22 ` [PATCH v1 2/8] x86/xen: simplify xen_oldmem_pfn_is_ram() David Hildenbrand
2021-09-29 0:59 ` Boris Ostrovsky
2021-09-29 8:45 ` David Hildenbrand
2021-09-29 9:03 ` David Hildenbrand
2021-09-29 14:22 ` Boris Ostrovsky
2021-09-29 15:07 ` David Hildenbrand [this message]
2021-09-28 18:22 ` [PATCH v1 3/8] proc/vmcore: let pfn_is_ram() return a bool David Hildenbrand
2021-09-28 18:22 ` [PATCH v1 4/8] proc/vmcore: convert oldmem_pfn_is_ram callback to more generic vmcore callbacks David Hildenbrand
2021-09-28 18:22 ` [PATCH v1 5/8] virtio-mem: factor out hotplug specifics from virtio_mem_init() into virtio_mem_init_hotplug() David Hildenbrand
2021-09-28 18:22 ` [PATCH v1 6/8] virtio-mem: factor out hotplug specifics from virtio_mem_probe() " David Hildenbrand
2021-09-28 18:22 ` [PATCH v1 7/8] virtio-mem: factor out hotplug specifics from virtio_mem_remove() into virtio_mem_deinit_hotplug() David Hildenbrand
2021-09-28 18:22 ` [PATCH v1 8/8] virtio-mem: kdump mode to sanitize /proc/vmcore access David Hildenbrand
2021-09-29 8:38 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6ace8c8-8a2d-9bf7-e65b-91d0037c4d08@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=jasowang@redhat.com \
--cc=jgross@suse.com \
--cc=kexec@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=osalvador@suse.de \
--cc=rafael.j.wysocki@intel.com \
--cc=rppt@kernel.org \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).