From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934257AbdACM4c (ORCPT ); Tue, 3 Jan 2017 07:56:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35988 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933987AbdACM40 (ORCPT ); Tue, 3 Jan 2017 07:56:26 -0500 Subject: Re: [PATCH v2 2/6] KVM: x86: decouple irqchip_in_kernel() and pic_irqchip() To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20161216151006.11776-1-rkrcmar@redhat.com> <20161216151006.11776-3-rkrcmar@redhat.com> Cc: Paolo Bonzini From: David Hildenbrand Organization: Red Hat GmbH Message-ID: Date: Tue, 3 Jan 2017 13:56:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161216151006.11776-3-rkrcmar@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 03 Jan 2017 12:56:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 16.12.2016 um 16:10 schrieb Radim Krčmář: > irqchip_in_kernel() tried to save a bit by reusing pic_irqchip(), but it > just complicated the code. > Add a separate state for the irqchip mode. > > Signed-off-by: Radim Krčmář > --- > v2: change two bools into one enum and rename everything [Paolo] > --- > arch/x86/include/asm/kvm_host.h | 8 +++++++- > arch/x86/kvm/irq.h | 15 ++++++++------- > arch/x86/kvm/x86.c | 5 +++-- > 3 files changed, 18 insertions(+), 10 deletions(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index 7892530cbacf..d3acd295446d 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -715,6 +715,12 @@ struct kvm_hv { > HV_REFERENCE_TSC_PAGE tsc_ref; > }; > > +enum kvm_irqchip_mode { > + KVM_IRQCHIP_NONE, > + KVM_IRQCHIP_KERNEL, /* created with KVM_CREATE_IRQCHIP */ > + KVM_IRQCHIP_SPLIT, /* created with KVM_CAP_SPLIT_IRQCHIP */ Was wondering if FULL/SPLIT would be a better naming. However I also find irqchip_kernel() vs irqchip_in_kernel() slightly confusing. Anyhow, with the suggestion of Paolo included, Reviewed-by: David Hildenbrand > +}; -- David