From: Vlastimil Babka <vbabka@suse.cz>
To: Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Matthew Wilcox <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Alistair Popple <apopple@nvidia.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@surriel.com>,
Suren Baghdasaryan <surenb@google.com>,
Yu Zhao <yuzhao@google.com>, Greg Thelen <gthelen@google.com>,
Shakeel Butt <shakeelb@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 09/13] mm/munlock: delete smp_mb() from __pagevec_lru_add_fn()
Date: Fri, 11 Feb 2022 18:43:36 +0100 [thread overview]
Message-ID: <e6b6c076-3826-b960-78c4-ccbbd686fc65@suse.cz> (raw)
In-Reply-To: <9121d34d-4889-51f1-56c7-255138f43b8d@google.com>
On 2/6/22 22:45, Hugh Dickins wrote:
> My reading of comment on smp_mb__after_atomic() in __pagevec_lru_add_fn()
> says that it can now be deleted; and that remains so when the next patch
> is added.
Agree with moderate certainty.
> Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/swap.c | 37 +++++++++----------------------------
> 1 file changed, 9 insertions(+), 28 deletions(-)
>
> diff --git a/mm/swap.c b/mm/swap.c
> index 682a03301a2c..3f770b1ea2c1 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -1025,37 +1025,18 @@ static void __pagevec_lru_add_fn(struct folio *folio, struct lruvec *lruvec)
>
> VM_BUG_ON_FOLIO(folio_test_lru(folio), folio);
>
> + folio_set_lru(folio);
> /*
> - * A folio becomes evictable in two ways:
> - * 1) Within LRU lock [munlock_vma_page() and __munlock_pagevec()].
> - * 2) Before acquiring LRU lock to put the folio on the correct LRU
> - * and then
> - * a) do PageLRU check with lock [check_move_unevictable_pages]
> - * b) do PageLRU check before lock [clear_page_mlock]
> - *
> - * (1) & (2a) are ok as LRU lock will serialize them. For (2b), we need
> - * following strict ordering:
> - *
> - * #0: __pagevec_lru_add_fn #1: clear_page_mlock
> - *
> - * folio_set_lru() folio_test_clear_mlocked()
> - * smp_mb() // explicit ordering // above provides strict
> - * // ordering
> - * folio_test_mlocked() folio_test_lru()
> + * Is an smp_mb__after_atomic() still required here, before
> + * folio_evictable() tests PageMlocked, to rule out the possibility
> + * of stranding an evictable folio on an unevictable LRU? I think
> + * not, because munlock_page() only clears PageMlocked while the LRU
> + * lock is held.
> *
> - *
> - * if '#1' does not observe setting of PG_lru by '#0' and
> - * fails isolation, the explicit barrier will make sure that
> - * folio_evictable check will put the folio on the correct
> - * LRU. Without smp_mb(), folio_set_lru() can be reordered
> - * after folio_test_mlocked() check and can make '#1' fail the
> - * isolation of the folio whose mlocked bit is cleared (#0 is
> - * also looking at the same folio) and the evictable folio will
> - * be stranded on an unevictable LRU.
> + * (That is not true of __page_cache_release(), and not necessarily
> + * true of release_pages(): but those only clear PageMlocked after
> + * put_page_testzero() has excluded any other users of the page.)
> */
> - folio_set_lru(folio);
> - smp_mb__after_atomic();
> -
> if (folio_evictable(folio)) {
> if (was_unevictable)
> __count_vm_events(UNEVICTABLE_PGRESCUED, nr_pages);
next prev parent reply other threads:[~2022-02-11 17:43 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 21:27 [PATCH 00/13] mm/munlock: rework of mlock+munlock page handling Hugh Dickins
2022-02-06 21:30 ` [PATCH 01/13] mm/munlock: delete page_mlock() and all its works Hugh Dickins
2022-02-09 18:31 ` Vlastimil Babka
2022-02-09 22:28 ` Hugh Dickins
2022-02-10 9:52 ` Vlastimil Babka
2022-02-14 6:52 ` Hugh Dickins
2022-02-14 6:59 ` [PATCH v2 " Hugh Dickins
2022-02-14 10:07 ` Vlastimil Babka
2022-02-06 21:32 ` [PATCH 02/13] mm/munlock: delete FOLL_MLOCK and FOLL_POPULATE Hugh Dickins
2022-02-10 11:35 ` Vlastimil Babka
2022-02-06 21:34 ` [PATCH 03/13] mm/munlock: delete munlock_vma_pages_all(), allow oomreap Hugh Dickins
2022-02-10 15:30 ` Vlastimil Babka
2022-02-06 21:36 ` [PATCH 04/13] mm/munlock: rmap call mlock_vma_page() munlock_vma_page() Hugh Dickins
2022-02-11 10:29 ` Vlastimil Babka
2022-02-14 7:05 ` [PATCH v2 " Hugh Dickins
2022-02-06 21:38 ` [PATCH 05/13] mm/munlock: replace clear_page_mlock() by final clearance Hugh Dickins
2022-02-11 11:42 ` Vlastimil Babka
2022-02-06 21:38 ` [PATCH 00/13] mm/munlock: rework of mlock+munlock page handling Matthew Wilcox
2022-02-07 18:20 ` Hugh Dickins
2022-02-06 21:40 ` [PATCH 06/13] mm/munlock: maintain page->mlock_count while unevictable Hugh Dickins
2022-02-11 12:27 ` Vlastimil Babka
2022-02-14 5:42 ` Hugh Dickins
2022-02-11 18:07 ` Vlastimil Babka
2022-02-14 6:28 ` Hugh Dickins
2022-02-06 21:42 ` [PATCH 07/13] mm/munlock: mlock_pte_range() when mlocking or munlocking Hugh Dickins
2022-02-11 16:45 ` Vlastimil Babka
2022-02-14 6:32 ` Hugh Dickins
2022-02-14 7:09 ` [PATCH v2 " Hugh Dickins
2022-02-06 21:43 ` [PATCH 08/13] mm/migrate: __unmap_and_move() push good newpage to LRU Hugh Dickins
2022-02-11 17:19 ` Vlastimil Babka
2022-02-06 21:45 ` [PATCH 09/13] mm/munlock: delete smp_mb() from __pagevec_lru_add_fn() Hugh Dickins
2022-02-11 17:43 ` Vlastimil Babka [this message]
2022-02-06 21:47 ` [PATCH 10/13] mm/munlock: mlock_page() munlock_page() batch by pagevec Hugh Dickins
2022-02-09 8:15 ` Geert Uytterhoeven
2022-02-09 15:45 ` Hugh Dickins
2022-02-11 18:26 ` Vlastimil Babka
2022-02-14 7:15 ` [PATCH v2 " Hugh Dickins
2022-02-06 21:49 ` [PATCH 11/13] mm/munlock: page migration needs mlock pagevec drained Hugh Dickins
2022-02-11 18:49 ` Vlastimil Babka
2022-02-14 5:34 ` Hugh Dickins
2022-02-14 7:17 ` [PATCH v2 " Hugh Dickins
2022-02-06 21:51 ` [PATCH 12/13] mm/thp: collapse_file() do try_to_unmap(TTU_BATCH_FLUSH) Hugh Dickins
2022-02-06 21:53 ` [PATCH 13/13] mm/thp: shrink_page_list() avoid splitting VM_LOCKED THP Hugh Dickins
[not found] ` <20220207033518.2602-1-hdanton@sina.com>
2022-02-07 18:46 ` [PATCH 07/13] mm/munlock: mlock_pte_range() when mlocking or munlocking Hugh Dickins
2022-02-09 15:35 ` [PATCH 00/13] mm/munlock: rework of mlock+munlock page handling Michal Hocko
2022-02-09 16:21 ` Hugh Dickins
2022-02-09 21:01 ` Michal Hocko
2022-02-09 22:59 ` Hugh Dickins
2022-02-10 7:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6b6c076-3826-b960-78c4-ccbbd686fc65@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=shakeelb@google.com \
--cc=surenb@google.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).