From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9503C4361B for ; Tue, 8 Dec 2020 01:19:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BA502054F for ; Tue, 8 Dec 2020 01:19:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726406AbgLHBTY (ORCPT ); Mon, 7 Dec 2020 20:19:24 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9551 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725814AbgLHBTY (ORCPT ); Mon, 7 Dec 2020 20:19:24 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cqj3Z6RjnzM20k; Tue, 8 Dec 2020 09:18:02 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 8 Dec 2020 09:18:37 +0800 Subject: Re: [f2fs-dev] [PATCH v3] f2fs: compress: support chksum To: Eric Biggers CC: , , References: <20201126103209.67985-1-yuchao0@huawei.com> From: Chao Yu Message-ID: Date: Tue, 8 Dec 2020 09:18:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/12/8 4:37, Eric Biggers wrote: > On Thu, Nov 26, 2020 at 06:32:09PM +0800, Chao Yu wrote: >> + if (!ret && fi->i_compress_flag & 1 << COMPRESS_CHKSUM) { > > This really could use some parentheses. People shouldn't have to look up a > C operator precedence table to understand the code. Will add parentheses to avoid misread. > >> + u32 provided = le32_to_cpu(dic->cbuf->chksum); >> + u32 calculated = f2fs_crc32(sbi, dic->cbuf->cdata, dic->clen); >> + >> + if (provided != calculated) { >> + if (!is_inode_flag_set(dic->inode, FI_COMPRESS_CORRUPT)) { >> + set_inode_flag(dic->inode, FI_COMPRESS_CORRUPT); >> + printk_ratelimited( >> + "%sF2FS-fs (%s): checksum invalid, nid = %lu, %x vs %x", >> + KERN_INFO, sbi->sb->s_id, dic->inode->i_ino, >> + provided, calculated); >> + } >> + set_sbi_flag(sbi, SBI_NEED_FSCK); >> + WARN_ON_ONCE(1); > > WARN, WARN_ON_ONCE, BUG, BUG_ON, etc. are only for kernel bugs, not for invalid > inputs from disk or userspace. > > There is already a log message printed just above, so it seems this WARN_ON_ONCE > should just be removed. Jaegeuk wants to give WARN_ON and marking a FSCK flag without returning EFSCORRUPTED, Jaegeuk, thoughts? Thanks, > > - Eric > . >