From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: "Zhangjiantao (Kirin, nanjing)" <water.zhangjiantao@huawei.com>,
"Xuetao (kirin)" <xuetao09@huawei.com>,
"mathias.nyman@intel.com" <mathias.nyman@intel.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "chenyu (U)" <chenyu56@huawei.com>,
Caiyadong <caiyadong@huawei.com>,
xuhaiyang <xuhaiyang5@hisilicon.com>
Subject: Re: [PATCH] xhci: solve a double free problem while doing s4
Date: Thu, 10 Jun 2021 16:45:54 +0300 [thread overview]
Message-ID: <e6ca9524-67a6-1eef-a44f-b9a1acd5205c@linux.intel.com> (raw)
In-Reply-To: <1428e2d7b7b74fccb3493384f96c521a@huawei.com>
On 9.6.2021 17.22, Zhangjiantao (Kirin, nanjing) wrote:
> when system is doing s4, the process of xhci_resume may be as below:
> 1、xhci_mem_cleanup
> 2、xhci_init->xhci_mem_init->xhci_mem_cleanup(when memory is not enough).
> xhci_mem_cleanup will be executed twice when system is out of memory.
> xhci->port_caps is freed in xhci_mem_cleanup,but it isn't set to NULL.
> It will be freed twice when xhci_mem_cleanup is called the second time.
>
Thanks, nice catch
> We got following bug when system resumes from s4:
>
> kernel BUG at mm/slub.c:309!
> Internal error: Oops - BUG: 0 [#1] PREEMPT SMP
> CPU: 0 PID: 5929 Tainted: G S W 5.4.96-arm64-desktop #1
> pc : __slab_free+0x5c/0x424
> lr : kfree+0x30c/0x32c
>
> Call trace:
> __slab_free+0x5c/0x424
> kfree+0x30c/0x32c
> xhci_mem_cleanup+0x394/0x3cc
> xhci_mem_init+0x9ac/0x1070
> xhci_init+0x8c/0x1d0
> xhci_resume+0x1cc/0x5fc
> xhci_plat_resume+0x64/0x70
> platform_pm_thaw+0x28/0x60
> dpm_run_callback+0x54/0x24c
> device_resume+0xd0/0x200
> async_resume+0x24/0x60
> async_run_entry_fn+0x44/0x110
> process_one_work+0x1f0/0x490
> worker_thread+0x5c/0x450
> kthread+0x158/0x160
> ret_from_fork+0x10/0x24
>
> Signed-off-by: Tao Xue <xuetao09@huawei.com>
Checkpatch complains:
ERROR: Missing Signed-off-by: line by nominal patch author 'Zhangjiantao (Kirin, nanjing) <water.zhangjiantao@huawei.com>'
Is Zhangjiantao (Kirin, nanjing) the correct author? If yes can I add
"Signed-off-by: Zhangjiantao (Kirin, nanjing) <water.zhangjiantao@huawei.com>?
I'll add the stable and correct fixes tags for this.
Thanks
Mathias
next prev parent reply other threads:[~2021-06-10 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1623244292-108534-1-git-send-email-xuetao09@huawei.com>
2021-06-09 14:22 ` [PATCH] xhci: solve a double free problem while doing s4 Zhangjiantao (Kirin, nanjing)
2021-06-10 13:45 ` Mathias Nyman [this message]
2021-06-10 14:01 ` gregkh
2021-06-10 19:27 ` Mathias Nyman
2021-06-11 7:18 ` Zhangjiantao (Kirin, nanjing)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6ca9524-67a6-1eef-a44f-b9a1acd5205c@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=caiyadong@huawei.com \
--cc=chenyu56@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=water.zhangjiantao@huawei.com \
--cc=xuetao09@huawei.com \
--cc=xuhaiyang5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).