From: Joe Perches <joe@perches.com>
To: Yunfeng Ye <yeyunfeng@huawei.com>,
apw@canonical.com, mingo@kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] toplevel: Move ipc/ to kernel/ipc/: don't check the ipc dir
Date: Wed, 25 Sep 2019 09:32:33 -0700 [thread overview]
Message-ID: <e6d097c176d4a4bb4fe5664fe4199f3025d22182.camel@perches.com> (raw)
In-Reply-To: <04acff22-430b-9ed7-f700-b644c0632cdd@huawei.com>
On Wed, 2019-09-25 at 20:37 +0800, Yunfeng Ye wrote:
> After the commit 76128326f97c ("toplevel: Move ipc/ to kernel/ipc/: move
> the files"), we met some error messages:
>
> ./scripts/checkpatch.pl:
> "Must be run from the top-level dir. of a kernel tree"
>
> ./scripts/get_maintainer.pl:
> "The current directory does not appear to be a linux kernel source tree.
>
> Don't check the ipc dir in checkpatch.pl and get_maintainer.pl.
Thanks.
Maybe the commit subject could use "scripts:"
or something similar and not "toplevel:".
Trivially, it one day it'd be good to use the
same routine and output message too.
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
> ---
> scripts/checkpatch.pl | 2 +-
> scripts/get_maintainer.pl | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 93a7edf..6117d0e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1097,7 +1097,7 @@ sub top_of_kernel_tree {
> my @tree_check = (
> "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
> "README", "Documentation", "arch", "include", "drivers",
> - "fs", "init", "ipc", "kernel", "lib", "scripts",
> + "fs", "init", "kernel", "lib", "scripts",
> );
>
> foreach my $check (@tree_check) {
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 5ef5921..2e42aeb 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -1109,7 +1109,6 @@ sub top_of_kernel_tree {
> && (-d "${lk_path}drivers")
> && (-d "${lk_path}fs")
> && (-d "${lk_path}init")
> - && (-d "${lk_path}ipc")
> && (-d "${lk_path}kernel")
> && (-d "${lk_path}lib")
> && (-d "${lk_path}scripts")) {
next prev parent reply other threads:[~2019-09-25 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 12:37 [PATCH] toplevel: Move ipc/ to kernel/ipc/: don't check the ipc dir Yunfeng Ye
2019-09-25 16:32 ` Joe Perches [this message]
2019-09-26 1:18 ` Yunfeng Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6d097c176d4a4bb4fe5664fe4199f3025d22182.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=yeyunfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).