From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83A32C54EE9 for ; Wed, 7 Sep 2022 09:55:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230156AbiIGJzU (ORCPT ); Wed, 7 Sep 2022 05:55:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230044AbiIGJzI (ORCPT ); Wed, 7 Sep 2022 05:55:08 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3943A24BF8; Wed, 7 Sep 2022 02:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662544507; x=1694080507; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=wTz5MbuOMBDOMBq3QKGowVOjTKfUFIGm8N9GEPakT7M=; b=hSCiyCvSJywfCOImk37gC1imW5dKcu0AUcQ1fB4LY6/l9MZxvorkAKHO /KZRjA/o5lz41Fh4AtAyd4e6og2T5K0msuUo8z5ob50bHqBqGRCDX524k RdHp6lOXbqRI7OqFPBtZvSg1P+73OACOKJw5BAOfzPWAVV1t3QHiPJkmJ tex9y1Gd7vN0cH0DW63j442YvsIQqG1ffPhYEf8k817nF0M+QEaMlMIme xupNTB90ibbPOuV4uCUejVx7M6T6z9AQ9Tb3qfpWM69Pzq9an7wmZ0CiE z3zeY9Xm/ioaxIcJvWA5bmE/mue6J55Nl0la11g6/Y/e8empIZNQBvE2J w==; X-IronPort-AV: E=McAfee;i="6500,9779,10462"; a="294415263" X-IronPort-AV: E=Sophos;i="5.93,296,1654585200"; d="scan'208";a="294415263" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 02:55:06 -0700 X-IronPort-AV: E=Sophos;i="5.93,296,1654585200"; d="scan'208";a="644551974" Received: from dmatouse-mobl.ger.corp.intel.com ([10.251.223.53]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2022 02:54:58 -0700 Date: Wed, 7 Sep 2022 12:54:57 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Jiri Slaby cc: Greg Kroah-Hartman , linux-serial , LKML , Tobias Klauser , Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Vladimir Zapolskiy , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , =?ISO-8859-15?Q?Andreas_F=E4rber?= , Manivannan Sadhasivam , Russell King , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, =?ISO-8859-15?Q?Pali_Roh=E1r?= , Kevin Cernekee , Palmer Dabbelt , Paul Walmsley , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 0/4] tty: TX helpers In-Reply-To: <20220906104805.23211-1-jslaby@suse.cz> Message-ID: References: <20220906104805.23211-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1229872048-1662544507=:1717" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1229872048-1662544507=:1717 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 6 Sep 2022, Jiri Slaby wrote: > This series introduces DEFINE_UART_PORT_TX_HELPER + > DEFINE_UART_PORT_TX_HELPER_LIMITED TX helpers. See PATCH 2/4 for the > details. Comments welcome. > > Then it switches drivers to use them. First, to > DEFINE_UART_PORT_TX_HELPER() in 3/4 and then > DEFINE_UART_PORT_TX_HELPER_LIMITED() in 4/4. > > The diffstat of patches 3+4 is as follows: > 26 files changed, 191 insertions(+), 823 deletions(-) > which appears to be nice. > > Cc: Tobias Klauser > Cc: Richard Genoud > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Claudiu Beznea > Cc: Vladimir Zapolskiy > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Lorenzo Pieralisi > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: "Andreas Färber" > Cc: Manivannan Sadhasivam > Cc: Russell King > Cc: Florian Fainelli > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: "Pali Rohár" > Cc: Kevin Cernekee > Cc: Palmer Dabbelt > Cc: Paul Walmsley > Cc: Orson Zhai > Cc: Baolin Wang > Cc: Chunyan Zhang > Cc: Patrice Chotard > Cc: linux-riscv@lists.infradead.org > > Jiri Slaby (4): > tty: serial: move and cleanup vt8500_tx_empty() > tty: serial: introduce transmit helper generators > tty: serial: use DEFINE_UART_PORT_TX_HELPER() > tty: serial: use DEFINE_UART_PORT_TX_HELPER_LIMITED() > > Documentation/driver-api/serial/driver.rst | 3 + > drivers/tty/serial/21285.c | 33 ++------- > drivers/tty/serial/altera_jtaguart.c | 42 +++-------- > drivers/tty/serial/altera_uart.c | 37 ++-------- > drivers/tty/serial/amba-pl010.c | 37 ++-------- > drivers/tty/serial/apbuart.c | 36 ++-------- > drivers/tty/serial/atmel_serial.c | 29 ++------ > drivers/tty/serial/bcm63xx_uart.c | 47 +++---------- > drivers/tty/serial/fsl_lpuart.c | 38 +++------- > drivers/tty/serial/lantiq.c | 44 ++++-------- > drivers/tty/serial/lpc32xx_hs.c | 38 ++-------- > drivers/tty/serial/mcf.c | 27 ++------ > drivers/tty/serial/mpc52xx_uart.c | 43 +----------- > drivers/tty/serial/mps2-uart.c | 29 +------- > drivers/tty/serial/mux.c | 46 ++++-------- > drivers/tty/serial/mvebu-uart.c | 40 ++--------- > drivers/tty/serial/mxs-auart.c | 31 ++------- > drivers/tty/serial/omap-serial.c | 47 ++++--------- > drivers/tty/serial/owl-uart.c | 35 +--------- > drivers/tty/serial/pxa.c | 39 +++-------- > drivers/tty/serial/rp2.c | 36 ++-------- > drivers/tty/serial/sa1100.c | 49 +++++-------- > drivers/tty/serial/serial_txx9.c | 37 ++-------- > drivers/tty/serial/sifive.c | 45 ++---------- > drivers/tty/serial/sprd_serial.c | 38 ++-------- > drivers/tty/serial/st-asc.c | 50 ++----------- > drivers/tty/serial/vt8500_serial.c | 40 ++--------- > include/linux/serial_core.h | 81 ++++++++++++++++++++++ > 28 files changed, 275 insertions(+), 822 deletions(-) For the whole series: Reviewed-by: Ilpo Järvinen -- i. --8323329-1229872048-1662544507=:1717--