From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 103BFC433E1 for ; Tue, 2 Jun 2020 09:07:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA6C020738 for ; Tue, 2 Jun 2020 09:07:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726630AbgFBJHr (ORCPT ); Tue, 2 Jun 2020 05:07:47 -0400 Received: from mx.socionext.com ([202.248.49.38]:5666 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbgFBJHq (ORCPT ); Tue, 2 Jun 2020 05:07:46 -0400 Received: from unknown (HELO kinkan-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 02 Jun 2020 18:07:43 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by kinkan-ex.css.socionext.com (Postfix) with ESMTP id BB527180B46; Tue, 2 Jun 2020 18:07:43 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Tue, 2 Jun 2020 18:07:43 +0900 Received: from yuzu.css.socionext.com (yuzu [172.31.8.45]) by kinkan.css.socionext.com (Postfix) with ESMTP id 673931A0E67; Tue, 2 Jun 2020 18:07:43 +0900 (JST) Received: from [10.213.31.100] (unknown [10.213.31.100]) by yuzu.css.socionext.com (Postfix) with ESMTP id BC777120136; Tue, 2 Jun 2020 18:07:42 +0900 (JST) Subject: Re: [PATCH v2 4/5] PCI: uniphier: Add iATU register support To: Rob Herring Cc: Bjorn Helgaas , Lorenzo Pieralisi , Jingoo Han , Gustavo Pimentel , Masahiro Yamada , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Masami Hiramatsu , Jassi Brar References: <1589536743-6684-1-git-send-email-hayashi.kunihiko@socionext.com> <1589536743-6684-5-git-send-email-hayashi.kunihiko@socionext.com> <20200601213215.GA1521885@bogus> From: Kunihiko Hayashi Message-ID: Date: Tue, 2 Jun 2020 18:07:42 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200601213215.GA1521885@bogus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob, On 2020/06/02 6:32, Rob Herring wrote: > On Fri, May 15, 2020 at 06:59:02PM +0900, Kunihiko Hayashi wrote: >> This gets iATU register area from reg property. In Synopsis DWC version >> 4.80 or later, since iATU register area is separated from core register >> area, this area is necessary to get from DT independently. >> >> Signed-off-by: Kunihiko Hayashi >> --- >> drivers/pci/controller/dwc/pcie-uniphier.c | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c >> index a8dda39..493f105 100644 >> --- a/drivers/pci/controller/dwc/pcie-uniphier.c >> +++ b/drivers/pci/controller/dwc/pcie-uniphier.c >> @@ -447,6 +447,13 @@ static int uniphier_pcie_probe(struct platform_device *pdev) >> if (IS_ERR(priv->pci.dbi_base)) >> return PTR_ERR(priv->pci.dbi_base); >> >> + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "atu"); >> + if (res) { >> + priv->pci.atu_base = devm_pci_remap_cfg_resource(dev, res); > > This isn't config space, so this function shouldn't be used. > > Use devm_platform_ioremap_resource_byname(). Indeed. I'll replace with it. >> + if (IS_ERR(priv->pci.atu_base)) >> + priv->pci.atu_base = NULL; >> + } >> + >> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "link"); >> priv->base = devm_ioremap_resource(dev, res); > > Feel free to convert this one too. This should be replaced as well. Thank you, --- Best Regards Kunihiko Hayashi