From: Marek Vasut <marek.vasut@gmail.com>
To: Nicholas Mc Guire <der.herr@hofr.at>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] mtd: spi-nor: intel: use true/false for boolean
Date: Tue, 14 Feb 2017 05:52:48 +0100 [thread overview]
Message-ID: <e6f01423-4ec7-33b3-b7a4-6af275525d2c@gmail.com> (raw)
In-Reply-To: <1486973636-1117-1-git-send-email-der.herr@hofr.at>
On 02/13/2017 09:13 AM, Nicholas Mc Guire wrote:
> writeable in struct intel_spi is a boolean and assignment should be to
> true/false not 1/0 as recommended by boolinit.cocci.
>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
>
> make coccicheck complained with:
> ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
>
> Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
>
> Patch is against 4.10-rc7 (localversion-next is next-20170213)
>
> drivers/mtd/spi-nor/intel-spi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> index 4630716..2956f2c 100644
> --- a/drivers/mtd/spi-nor/intel-spi.c
> +++ b/drivers/mtd/spi-nor/intel-spi.c
> @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
> * whole partition read-only to be on the safe side.
> */
> if (intel_spi_is_protected(ispi, base, limit))
> - ispi->writeable = 0;
> + ispi->writeable = false;
>
> end = (limit << 12) + 4096;
> if (end > part->size)
>
Looks OK, also this is the only place in the driver where writeable is
assigned to an explicit true/false value.
Acked-by: Marek Vasut <marek.vasut@gmail.com>
btw the variable should be renamed from writeable to writable ;-)
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-02-14 5:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 8:13 [PATCH V2] mtd: spi-nor: intel: use true/false for boolean Nicholas Mc Guire
2017-02-14 4:52 ` Marek Vasut [this message]
2017-02-14 9:57 ` Mika Westerberg
2017-02-15 21:08 ` Marek Vasut
2017-03-07 21:06 ` Cyrille Pitchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6f01423-4ec7-33b3-b7a4-6af275525d2c@gmail.com \
--to=marek.vasut@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=der.herr@hofr.at \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).