From: Lu Baolu <baolu.lu@linux.intel.com>
To: Qian Cai <cai@lca.pw>, jroedel@suse.de
Cc: baolu.lu@linux.intel.com, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] iommu/dmar: silence RCU-list debugging warnings
Date: Sat, 7 Mar 2020 19:53:05 +0800 [thread overview]
Message-ID: <e70ebe24-d3cb-79c7-9104-f0c3a5b62918@linux.intel.com> (raw)
In-Reply-To: <1583439302-11393-1-git-send-email-cai@lca.pw>
Hi,
On 2020/3/6 4:15, Qian Cai wrote:
> Similar to the commit 02d715b4a818 ("iommu/vt-d: Fix RCU list debugging
> warnings"), there are several other places that call
> list_for_each_entry_rcu() outside of an RCU read side critical section
> but with dmar_global_lock held. Silence those false positives as well.
>
> drivers/iommu/intel-iommu.c:4288 RCU-list traversed in non-reader section!!
> 1 lock held by swapper/0/1:
> #0: ffffffff935892c8 (dmar_global_lock){+.+.}, at: intel_iommu_init+0x1ad/0xb97
>
> drivers/iommu/dmar.c:366 RCU-list traversed in non-reader section!!
> 1 lock held by swapper/0/1:
> #0: ffffffff935892c8 (dmar_global_lock){+.+.}, at: intel_iommu_init+0x125/0xb97
>
> drivers/iommu/intel-iommu.c:5057 RCU-list traversed in non-reader section!!
> 1 lock held by swapper/0/1:
> #0: ffffffffa71892c8 (dmar_global_lock){++++}, at: intel_iommu_init+0x61a/0xb13
>
> Signed-off-by: Qian Cai <cai@lca.pw>
Thanks for the fix.
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
> ---
> drivers/iommu/dmar.c | 3 ++-
> include/linux/dmar.h | 6 ++++--
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
> index 071bb42bbbc5..7b16c4db40b4 100644
> --- a/drivers/iommu/dmar.c
> +++ b/drivers/iommu/dmar.c
> @@ -363,7 +363,8 @@ static int dmar_pci_bus_notifier(struct notifier_block *nb,
> {
> struct dmar_drhd_unit *dmaru;
>
> - list_for_each_entry_rcu(dmaru, &dmar_drhd_units, list)
> + list_for_each_entry_rcu(dmaru, &dmar_drhd_units, list,
> + dmar_rcu_check())
> if (dmaru->segment == drhd->segment &&
> dmaru->reg_base_addr == drhd->address)
> return dmaru;
> diff --git a/include/linux/dmar.h b/include/linux/dmar.h
> index 712be8bc6a7c..d7bf029df737 100644
> --- a/include/linux/dmar.h
> +++ b/include/linux/dmar.h
> @@ -74,11 +74,13 @@ struct dmar_pci_notify_info {
> dmar_rcu_check())
>
> #define for_each_active_drhd_unit(drhd) \
> - list_for_each_entry_rcu(drhd, &dmar_drhd_units, list) \
> + list_for_each_entry_rcu(drhd, &dmar_drhd_units, list, \
> + dmar_rcu_check()) \
> if (drhd->ignored) {} else
>
> #define for_each_active_iommu(i, drhd) \
> - list_for_each_entry_rcu(drhd, &dmar_drhd_units, list) \
> + list_for_each_entry_rcu(drhd, &dmar_drhd_units, list, \
> + dmar_rcu_check()) \
> if (i=drhd->iommu, drhd->ignored) {} else
>
> #define for_each_iommu(i, drhd) \
>
next prev parent reply other threads:[~2020-03-07 11:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 20:15 [PATCH -next] iommu/dmar: silence RCU-list debugging warnings Qian Cai
2020-03-07 11:53 ` Lu Baolu [this message]
2020-03-10 9:31 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e70ebe24-d3cb-79c7-9104-f0c3a5b62918@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=cai@lca.pw \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).