From: John Garry <john.garry@huawei.com>
To: Pavel Begunkov <asml.silence@gmail.com>,
Jens Axboe <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
Omar Sandoval <osandov@osandov.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] sbitmap: optimise sbitmap_deferred_clear()
Date: Tue, 24 Nov 2020 14:11:51 +0000 [thread overview]
Message-ID: <e71a58b5-1315-d655-4e1e-cd7529acfd6b@huawei.com> (raw)
In-Reply-To: <ddfa166d93f38e812751b6ff986fd5403b7893b7.1606058975.git.asml.silence@gmail.com>
On 22/11/2020 15:35, Pavel Begunkov wrote:
> Because of spinlocks and atomics sbitmap_deferred_clear() have to reload
> &sb->map[index] on each access even though the map address won't change.
> Pass in sbitmap_word instead of {sb, index}, so it's cached in a
> variable. It also improves code generation of
> sbitmap_find_bit_in_index().
>
> Signed-off-by: Pavel Begunkov<asml.silence@gmail.com>
Looks ok, even though a bit odd not be passing a struct sbitmap * now
Reviewed-by: John Garry <john.garry@huawei.com>
next prev parent reply other threads:[~2020-11-24 14:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 15:35 [PATCH v2 for-next 0/4] optimise sbitmap deferred clear Pavel Begunkov
2020-11-22 15:35 ` [PATCH v2 1/4] sbitmap: optimise sbitmap_deferred_clear() Pavel Begunkov
2020-11-24 14:11 ` John Garry [this message]
2020-11-24 15:01 ` Pavel Begunkov
2020-11-22 15:35 ` [PATCH v2 2/4] sbitmap: remove swap_lock Pavel Begunkov
2020-11-24 14:22 ` John Garry
2020-11-24 14:43 ` Pavel Begunkov
2020-11-26 2:46 ` Ming Lei
2020-11-26 13:44 ` Pavel Begunkov
2020-11-27 2:06 ` Ming Lei
2020-11-22 15:35 ` [PATCH v2 3/4] sbitmap: replace CAS with atomic and Pavel Begunkov
2020-11-22 15:35 ` [PATCH v2 4/4] sbitmap: simplify wrap check Pavel Begunkov
2020-12-08 0:13 ` [PATCH v2 for-next 0/4] optimise sbitmap deferred clear Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e71a58b5-1315-d655-4e1e-cd7529acfd6b@huawei.com \
--to=john.garry@huawei.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).