From: Philippe CORNU <philippe.cornu@st.com>
To: Yannick FERTRE <yannick.fertre@st.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"Alexandre TORGUE" <alexandre.torgue@st.com>,
Etienne CARRIERE <etienne.carriere@st.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: platform: stm32: defer probe for auxiliary clock
Date: Thu, 23 Jan 2020 09:52:50 +0000 [thread overview]
Message-ID: <e7573c97-7c88-bb3d-1bfb-dea92f146da9@st.com> (raw)
In-Reply-To: <1579602152-7432-1-git-send-email-yannick.fertre@st.com>
Dears Yannick & Etienne,
Thank you for your patch,
Reviewed-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
On 1/21/20 11:22 AM, Yannick Fertre wrote:
> From: Etienne Carriere <etienne.carriere@st.com>
>
> Change stm32-cec driver to defer probe when auxiliary clock
> "hdmi-cec" is registered in the system not has not been probed yet.
>
> Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
> ---
> drivers/media/platform/stm32/stm32-cec.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/stm32/stm32-cec.c b/drivers/media/platform/stm32/stm32-cec.c
> index 8a86b2c..543c9ec 100644
> --- a/drivers/media/platform/stm32/stm32-cec.c
> +++ b/drivers/media/platform/stm32/stm32-cec.c
> @@ -302,10 +302,14 @@ static int stm32_cec_probe(struct platform_device *pdev)
> }
>
> cec->clk_hdmi_cec = devm_clk_get(&pdev->dev, "hdmi-cec");
> + if (IS_ERR(cec->clk_hdmi_cec) &&
> + PTR_ERR(cec->clk_hdmi_cec) == -EPROBE_DEFER)
> + return -EPROBE_DEFER;
> +
> if (!IS_ERR(cec->clk_hdmi_cec)) {
> ret = clk_prepare(cec->clk_hdmi_cec);
> if (ret) {
> - dev_err(&pdev->dev, "Unable to prepare hdmi-cec clock\n");
> + dev_err(&pdev->dev, "Can't prepare hdmi-cec clock\n");
> return ret;
> }
> }
>
prev parent reply other threads:[~2020-01-23 9:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 10:22 [PATCH] media: platform: stm32: defer probe for auxiliary clock Yannick Fertre
2020-01-23 9:52 ` Philippe CORNU [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7573c97-7c88-bb3d-1bfb-dea92f146da9@st.com \
--to=philippe.cornu@st.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=etienne.carriere@st.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).