From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967591AbeEYRuW (ORCPT ); Fri, 25 May 2018 13:50:22 -0400 Received: from gateway34.websitewelcome.com ([192.185.149.105]:39405 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967413AbeEYRuV (ORCPT ); Fri, 25 May 2018 13:50:21 -0400 X-Authority-Reason: nr=8 Subject: Re: [PATCH] ath6kl: mark expected switch fall-throughs To: Kalle Valo , Sergei Shtylyov Cc: "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180524231322.GA22704@embeddedor.com> <060f93a0-7210-79b6-37a7-cd8900719d40@cogentembedded.com> <871sdzc16l.fsf@kamboji.qca.qualcomm.com> From: "Gustavo A. R. Silva" Message-ID: Date: Fri, 25 May 2018 12:50:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <871sdzc16l.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.192.46.223 X-Source-L: No X-Exim-ID: 1fMGr5-003Mxc-N7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.70]) [187.192.46.223]:54406 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/25/2018 08:30 AM, Kalle Valo wrote: > Sergei Shtylyov writes: > >> On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote: >> >>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>> where we are expecting to fall through. >>> >>> Signed-off-by: Gustavo A. R. Silva >>> --- >>> drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c >>> index 2ba8cf3..29e32cd 100644 >>> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c >>> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c >>> @@ -3898,17 +3898,17 @@ int ath6kl_cfg80211_init(struct ath6kl *ar) >>> wiphy->max_scan_ie_len = 1000; /* FIX: what is correct limit? */ >>> switch (ar->hw.cap) { >>> case WMI_11AN_CAP: >>> - ht = true; >>> + ht = true; /* fall through */ >>> case WMI_11A_CAP: >>> band_5gig = true; >>> break; >>> case WMI_11GN_CAP: >>> - ht = true; >>> + ht = true; /* fall through */ >>> case WMI_11G_CAP: >>> band_2gig = true; >>> break; >>> case WMI_11AGN_CAP: >>> - ht = true; >>> + ht = true; /* fall through */ >>> case WMI_11AG_CAP: >>> band_2gig = true; >>> band_5gig = true; >> >> Hm, typically such comments are done on a line of their own, have >> never seen this style... > > Yeah, I was wondering the same. Was there a particular reason for this? > Sometimes people use this style for a one-line code block. I can change it to the traditional style. No problem. Thanks -- Gustavo