linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nam Cao <namcaov@gmail.com>
To: lkp@intel.com
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
	hdegoede@redhat.com, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	namcaov@gmail.com
Subject: [PATCH v2 4/8] staging: rtl8723bs: remove function GetFractionValueFromString
Date: Fri, 19 Aug 2022 15:49:38 +0200	[thread overview]
Message-ID: <e782bcd3ff8c33df8da7eb6b8e4bb00b1c270edc.1660916523.git.namcaov@gmail.com> (raw)
In-Reply-To: <cover.1660916523.git.namcaov@gmail.com>

because this function is not used.

Signed-off-by: Nam Cao <namcaov@gmail.com>
---
 drivers/staging/rtl8723bs/hal/hal_com.c     | 43 ---------------------
 drivers/staging/rtl8723bs/include/hal_com.h |  3 --
 2 files changed, 46 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 909b37bcc897..f82cbe5a77ff 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -939,49 +939,6 @@ bool GetHexValueFromString(char *szStr, u32 *pu4bVal, u32 *pu4bMove)
 	return true;
 }
 
-bool GetFractionValueFromString(
-	char *szStr, u8 *pInteger, u8 *pFraction, u32 *pu4bMove
-)
-{
-	char *szScan = szStr;
-
-	/*  Initialize output. */
-	*pu4bMove = 0;
-	*pInteger = 0;
-	*pFraction = 0;
-
-	/*  Skip leading space. */
-	while (*szScan != '\0' &&	(*szScan == ' ' || *szScan == '\t')) {
-		++szScan;
-		++(*pu4bMove);
-	}
-
-	/*  Parse each digit. */
-	do {
-		(*pInteger) *= 10;
-		*pInteger += (*szScan - '0');
-
-		++szScan;
-		++(*pu4bMove);
-
-		if (*szScan == '.') {
-			++szScan;
-			++(*pu4bMove);
-
-			if (*szScan < '0' || *szScan > '9')
-				return false;
-			else {
-				*pFraction = *szScan - '0';
-				++szScan;
-				++(*pu4bMove);
-				return true;
-			}
-		}
-	} while (*szScan >= '0' && *szScan <= '9');
-
-	return true;
-}
-
 /*  */
 /* 	Description: */
 /* 		Return true if szStr is comment out with leading "//". */
diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/rtl8723bs/include/hal_com.h
index 7be0ea20bca4..b49b0a0355c6 100644
--- a/drivers/staging/rtl8723bs/include/hal_com.h
+++ b/drivers/staging/rtl8723bs/include/hal_com.h
@@ -153,9 +153,6 @@ u32 MapCharToHexDigit(char chTmp);
 
 bool GetHexValueFromString(char *szStr, u32 *pu4bVal, u32 *pu4bMove);
 
-bool GetFractionValueFromString(char *szStr, u8 *pInteger, u8 *pFraction,
-				u32 *pu4bMove);
-
 bool IsCommentString(char *szStr);
 
 bool ParseQualifiedString(char *In, u32 *Start, char *Out, char LeftQualifier,
-- 
2.25.1


  parent reply	other threads:[~2022-08-19 13:50 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19  8:52 [PATCH 0/7] staging: rtl8723bs: remove dead functions Nam Cao
2022-08-19  8:52 ` [PATCH 1/7] staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg Nam Cao
2022-08-19 13:07   ` kernel test robot
2022-08-19 13:49     ` [PATCH v2 0/8] remove some dead code Nam Cao
2022-08-19 13:49       ` [PATCH v2 1/8] staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg Nam Cao
2022-08-22  7:33         ` Dan Carpenter
2022-08-22  7:47           ` Nam Cao
2022-08-19 13:49       ` [PATCH v2 2/8] staging: rtl8723bs: remove function rtw_get_ch_setting_union Nam Cao
2022-08-19 13:49       ` [PATCH v2 3/8] staging: rtl8723bs: remove function rtw_odm_ability_set Nam Cao
2022-08-19 13:49       ` Nam Cao [this message]
2022-08-19 13:49       ` [PATCH v2 5/8] staging: rtl8723bs: remove function IsCommentString Nam Cao
2022-08-19 13:49       ` [PATCH v2 6/8] staging: rtl8723bs: remove function rtw_odm_adaptivity_parm_msg Nam Cao
2022-08-19 13:49       ` [PATCH v2 7/8] staging: rtl8723bs: remove function rtw_odm_dbg_comp_set Nam Cao
2022-08-19 13:49       ` [PATCH v2 8/8] staging: rtl8723bs: remove static const variable odm_comp_str Nam Cao
2022-08-19 14:25       ` [PATCH v2 0/8] remove some dead code Hans de Goede
2022-08-19  8:52 ` [PATCH 2/7] staging: rtl8723bs: remove function rtw_get_ch_setting_union Nam Cao
2022-08-19  8:52 ` [PATCH 3/7] staging: rtl8723bs: remove function rtw_odm_ability_set Nam Cao
2022-08-19  8:52 ` [PATCH 4/7] staging: rtl8723bs: remove function GetFractionValueFromString Nam Cao
2022-08-19  8:52 ` [PATCH 5/7] staging: rtl8723bs: remove function IsCommentString Nam Cao
2022-08-19  8:52 ` [PATCH 6/7] staging: rtl8723bs: remove function rtw_odm_adaptivity_parm_msg Nam Cao
2022-08-19  8:52 ` [PATCH 7/7] staging: rtl8723bs: remove function rtw_odm_dbg_comp_set Nam Cao
2022-08-19  9:06 ` [PATCH 0/7] staging: rtl8723bs: remove dead functions Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e782bcd3ff8c33df8da7eb6b8e4bb00b1c270edc.1660916523.git.namcaov@gmail.com \
    --to=namcaov@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).